Skip to content

Fix locale override and settings menu for API key auth on Linux - #401

Merged
ilysenko merged 2 commits into
ilysenko:mainfrom
losese:pr-linux-locale-settings
Jun 3, 2026
Merged

Fix locale override and settings menu for API key auth on Linux#401
ilysenko merged 2 commits into
ilysenko:mainfrom
losese:pr-linux-locale-settings

Conversation

@losese

@losese losese commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Summary

This PR fixes two Linux webview compatibility issues that affect users who do not sign in with an official ChatGPT account and instead authenticate with an API key, including third-party API-compatible endpoints/keys.

  • Respect an explicit localeOverride even when the upstream enable_i18n gate is disabled.
  • Show the existing Settings menu item in the profile dropdown on Linux.

User-visible behavior

Before this change, API key authenticated users could set a locale override, but the webview i18n provider and language settings row could still stay behind the upstream enable_i18n gate. In that state, Chinese and other localized UI strings were not shown.

The profile dropdown also hid the Settings item behind an upstream feature gate, even though the Settings route itself was reachable through other UI paths, such as the archived conversation toast link.

After this change:

  • explicit locale overrides work for API key auth on Linux
  • the Settings item is visible from the profile dropdown
  • the locale patch preserves React hook order by reusing the existing unconditional locale override hook result

Validation

  • codex-app/resources/node-runtime/bin/node --test scripts/patch-linux-window-ui.test.js
  • Fresh temporary build:
    • CODEX_INSTALL_DIR=/tmp/codex-app-pr-locale-settings ./install.sh --fresh ""
  • Checked generated webview bundles for the patched i18n/settings shapes.
  • Ran node --check on the generated patched webview bundles.

@losese
losese force-pushed the pr-linux-locale-settings branch from 234bdd5 to 76a3858 Compare June 3, 2026 14:23

@ilysenko ilysenko left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed current head. The webview patches are scoped, fail-soft, covered by focused tests, and CI is green.

@ilysenko
ilysenko merged commit 53d18da into ilysenko:main Jun 3, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants