Fix locale override and settings menu for API key auth on Linux - #401
Merged
Conversation
losese
force-pushed
the
pr-linux-locale-settings
branch
from
June 3, 2026 14:23
234bdd5 to
76a3858
Compare
ilysenko
approved these changes
Jun 3, 2026
ilysenko
left a comment
Owner
There was a problem hiding this comment.
Reviewed current head. The webview patches are scoped, fail-soft, covered by focused tests, and CI is green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes two Linux webview compatibility issues that affect users who do not sign in with an official ChatGPT account and instead authenticate with an API key, including third-party API-compatible endpoints/keys.
localeOverrideeven when the upstreamenable_i18ngate is disabled.User-visible behavior
Before this change, API key authenticated users could set a locale override, but the webview i18n provider and language settings row could still stay behind the upstream
enable_i18ngate. In that state, Chinese and other localized UI strings were not shown.The profile dropdown also hid the Settings item behind an upstream feature gate, even though the Settings route itself was reachable through other UI paths, such as the archived conversation toast link.
After this change:
Validation
codex-app/resources/node-runtime/bin/node --test scripts/patch-linux-window-ui.test.jsCODEX_INSTALL_DIR=/tmp/codex-app-pr-locale-settings ./install.sh --fresh ""node --checkon the generated patched webview bundles.