Handle missing polkit auth agent in updater - #396
Conversation
|
@moxw Two blockers before this can be merged:
|
|
Thanks. I updated docs/updater.md in 94f27a3 to describe the pkexec/manual sudo fallback. On the class-style updater bridge: I am intentionally leaving that path unchanged in this PR. The current upstream Electron app uses the bootstrap updater bridge, and this PR is scoped to the current upstream bundle shape. The class-style bridge is retained compatibility for older bundle shapes, and expanding this fix there would broaden the patch/test surface beyond the current app path we need to support. |
ilysenko
left a comment
There was a problem hiding this comment.
Reviewed current head. The docs blocker is fixed, and I am accepting the class-style updater bridge as legacy compatibility outside the current upstream bundle path. Current upstream/bootstrap path is covered and CI is green.
Summary
User-visible behavior
Clicking the in-app update button in minimal window-manager sessions without a graphical polkit agent no longer quits Codex into a failed pkexec path. The updater leaves the package ready and shows/reports the manual terminal command instead.
Validation