Skip to content

Commit

Permalink
chore: update bump script to use lerna flag --exact (aws#4510)
Browse files Browse the repository at this point in the history
Follow-up to aws#4470 - specifying this flag to specify cross-dependency
version numbers exactly rather than with a caret(^).

Minor fix to display the expected version when we're checking
that dependencies use point versions.
  • Loading branch information
shivlaks authored and mergify[bot] committed Oct 15, 2019
1 parent 87458c1 commit 7c73bfb
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion bump.sh
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export NODE_OPTIONS="--max-old-space-size=4096 ${NODE_OPTIONS:-}"

/bin/bash ./install.sh

npx lerna version ${version} --force-publish=* --no-git-tag-version --no-push
npx lerna version ${version} --exact --force-publish=* --no-git-tag-version --no-push

# Another round of install to fix package-lock.jsons
/bin/bash ./install.sh
Expand Down
2 changes: 1 addition & 1 deletion packages/@aws-cdk/core/lib/construct.ts
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ export class ConstructNode {
/**
* Returns the child construct that has the id `Default` or `Resource"`.
* This is usually the construct that provides the bulk of the underlying functionality.
* Useful for modifications of the underlying construct that are not avialable at the higher levels.
* Useful for modifications of the underlying construct that are not available at the higher levels.
*
* @throws if there is more than one child
* @returns a construct or undefined if there is no default child
Expand Down
2 changes: 1 addition & 1 deletion tools/pkglint/lib/rules.ts
Original file line number Diff line number Diff line change
Expand Up @@ -653,7 +653,7 @@ export class MustDependonCdkByPointVersions extends ValidationRule {

pkg.report({
ruleName: this.name,
message: `dependency ${depName}: dependency version must be ${monoRepoVersion}`,
message: `dependency ${depName}: dependency version must be ${expectedVersion}`,
fix: () => pkg.addDependency(depName, expectedVersion)
});
}
Expand Down

0 comments on commit 7c73bfb

Please sign in to comment.