#473 serveless implementation using aws compute engine and serverless fram… by dheeraj-mummareddy · Pull Request #714 · iluwatar/java-design-patterns

dheeraj-mummareddy · 2018-02-08T17:08:49Z

serveless implementation using aws compute engine and serverless framework

serverless example implementation using aws compute engine and serverless framework
function creates an info endpoint which provides data from lambda context
resolves: Serverless pattern #473 Serverless pattern

Pull request description

Implementation and documentation using aws compute engine and serverless framework

…ework

roman-marcu · 2018-02-13T07:41:13Z

Hi, AWS is a Serverless FaaS technique, but what about BaaS? According to https://martinfowler.com/articles/serverless.html serverless is not just about moving server side code into some ephemeral function, but also integration of third party remote application services directly into the front-end of our app, as an example for BaaS https://firebase.google.com/docs/database/.

It would be nice to add a gateway API and to do 2 calls, one for AWS(FaaS) and other for firebase, or others,(BaaS).

dheeraj-mummareddy · 2018-02-13T14:33:29Z

@roman-marcu acknowledge, will add BaaS endpoints... API gateway is already configured in the stack which is created by serverless framework, will expand documentation, please take a look at http section in serverless yaml
https://serverless.com/framework/docs/providers/aws/events/apigateway/

iluwatar · 2018-03-04T06:39:42Z

@dheeraj-mummareddy the pull request has conflicts. Can you check it?

dheeraj-mummareddy · 2018-03-06T14:48:05Z

@iluwatar the PR is ready for review, the build passes locally but is not healthy in travis and looks like its failing for all other commits too. Is someone looking at the failure?

[INFO] throttling ......................................... FAILURE [ 2.287 s]

iluwatar · 2018-03-11T19:42:36Z

It is a known issue #643, still unresolved

iluwatar · 2018-03-11T19:43:39Z

serverless/README.md

+categories: Architectural
+tags:
+ - Java
+ - Difficulty-Intermittent


Difficulty-Intermediate?

@iluwatar I feel like the difficulty level is Intermediate based on the complexity to adopt, but let me know your thoughts?

I mean literally, Difficulty-Intermittent is wrong...

@iluwatar good catch, I think I copied the initial template from EIP patter, yup...will fix that with an other PR.

iluwatar · 2018-03-11T19:45:00Z

serverless/README.md

+* Serviceful operations
+    * Automated operations
+    * monitored applications
+    * Innovation mindset


Any links that would explain more about these katas? The terms alone are not enough.

iluwatar · 2018-03-11T19:47:17Z

serverless/README.md

+## AWS lambda function implementation
+
+AWS lambda SDK provides pre-defined interface `com.amazonaws.services.lambda.runtime
+.RequestHandler` to implement our lambda function. 


Link to AWS lambda SDK?

iluwatar · 2018-03-11T19:49:18Z

serverless/README.md

+* cloud watch (log groups)
+* API Gateway (ApiGatewayRestApi) 
+* Lambda function
+* DynamoDB collection


Spelling, cloud formation -> CloudFormation, cloud watch -> CloudWatch

iluwatar · 2018-03-11T19:52:13Z

serverless/src/main/java/com/iluwatar/serverless/baas/model/Address.java

+import java.io.Serializable;
+
+/**
+ * Address Object


Address class, not an object

iluwatar · 2018-03-11T19:52:37Z

serverless/src/main/java/com/iluwatar/serverless/baas/model/Person.java

+import java.io.Serializable;
+
+/**
+ * Person Request


Person class, not a request

iluwatar · 2018-03-11T19:54:03Z

serverless/src/test/java/com/illuwatar/serverless/baas/api/FindPersonApiHandlerTest.java

+import static org.mockito.Mockito.verify;
+
+/**
+ * Created by dheeraj.mummar on 3/5/18.


Explain what the class does

iluwatar · 2018-03-11T19:54:19Z

serverless/src/test/java/com/illuwatar/serverless/baas/api/SavePersonApiHandlerTest.java

+import static org.mockito.Mockito.*;
+
+/**
+ * Created by dheeraj.mummar on 3/4/18.


Explain what the class does

iluwatar · 2018-03-11T19:54:47Z

serverless/src/test/java/com/iluwatar/serverless/faas/api/LambdaInfoApiHandlerTest.java

+import static org.mockito.Mockito.when;
+
+/**
+ * LambdaInfoApiHandlerTest


Explain what the class does

iluwatar · 2018-03-31T06:48:38Z

@dheeraj-mummareddy are you working on this? Please comment when you want another review.

dheeraj-mummareddy · 2018-04-02T00:23:06Z

@iluwatar yes, its ready for review. Thanks!

iluwatar

the package of the tests is misspelled java.com.illuwatar
not every new file has the required license header, run the build to generate them

iluwatar · 2018-04-08T12:42:03Z

serverless/README.md

+categories: Architectural
+tags:
+ - Java
+ - Difficulty-Intermittent


I mean literally, Difficulty-Intermittent is wrong...

iluwatar · 2018-04-08T12:45:02Z

serverless/pom.xml

+    <parent>
+        <groupId>com.iluwatar</groupId>
+        <artifactId>java-design-patterns</artifactId>
+        <version>1.19.0-SNAPSHOT</version>


Should be updated to 1.20.0-SNAPSHOT

iluwatar · 2018-04-08T12:51:20Z

@dheeraj-mummareddy please comment when the (minor) changes are done so we can proceed with the merge

dheeraj-mummareddy · 2018-04-08T14:58:08Z

@iluwatar change have been fixed.

iluwatar · 2018-04-08T17:02:13Z

Good work @dheeraj-mummareddy thank you very much for this contribution 👍

iluwatar · 2020-07-28T15:01:44Z

@all-contributors please add @dheeraj-mummareddy for code

allcontributors · 2020-07-28T15:01:57Z

@iluwatar

I've put up a pull request to add @dheeraj-mummareddy! 🎉

serveless implementation using aws compute engine and serverless fram…

7a7ba87

…ework

iluwatar added the status: under review label Mar 4, 2018

dheeraj-mummareddy added 7 commits March 4, 2018 17:33

Merge branch 'master' of github.com:iluwatar/java-design-patterns

49f8434

Merge branch 'master' of github.com:iluwatar/java-design-patterns

3894a0b

merge from upstream and fixing conflicts

af69738

adding backend as a service with lambda + api gateway + dynamodb

b2dd36f

update readme and ready for review

b260701

update readme and thanks to Amazon Web Services & cloud guru

678fa93

fixing typo

1432134

iluwatar requested changes Mar 11, 2018

View reviewed changes

dheeraj-mummareddy added 3 commits March 12, 2018 09:19

Merge branch 'master' of github.com:iluwatar/java-design-patterns

05a9c03

code review comments

3f9a5a2

fixing the link

c3b102e

iluwatar requested changes Apr 8, 2018

View reviewed changes

dheeraj-mummareddy added 3 commits April 8, 2018 10:38

Merge branch 'master' of github.com:iluwatar/java-design-patterns

7a13012

minor code review comments and Updating license header

40e5cc6

delete the incorrect package

522fbc0

iluwatar approved these changes Apr 8, 2018

View reviewed changes

iluwatar merged commit 379a825 into iluwatar:master Apr 8, 2018

allcontributors bot mentioned this pull request Jul 28, 2020

docs: add dheeraj-mummareddy as a contributor #1367

Merged

Uh oh!

Conversation

dheeraj-mummareddy commented Feb 8, 2018

Uh oh!

roman-marcu commented Feb 13, 2018

Uh oh!

dheeraj-mummareddy commented Feb 13, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

iluwatar commented Mar 4, 2018

Uh oh!

dheeraj-mummareddy commented Mar 6, 2018

Uh oh!

iluwatar commented Mar 11, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dheeraj-mummareddy Mar 13, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iluwatar commented Mar 31, 2018

Uh oh!

dheeraj-mummareddy commented Apr 2, 2018

Uh oh!

iluwatar left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iluwatar commented Apr 8, 2018

Uh oh!

dheeraj-mummareddy commented Apr 8, 2018

Uh oh!

iluwatar commented Apr 8, 2018

Uh oh!

iluwatar commented Jul 28, 2020

Uh oh!

allcontributors bot commented Jul 28, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dheeraj-mummareddy commented Feb 13, 2018 •

edited

Loading

dheeraj-mummareddy Mar 13, 2018 •

edited

Loading