Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Refactor Layered Architecture pattern #2936 #2938

Merged
merged 2 commits into from
Jun 15, 2024

Conversation

romannimets
Copy link
Contributor

What problem does this PR solve?

Ecco un possibile testo che potresti aggiungere nella tua pull request:


What problem does this PR solve?

This PR addresses a couple of specific issues in the Layered Architecture code example (#2936):

  1. Main Entry Point for Runner.java: Runner.java lacked a main entry point, preventing it from being executed directly in an IDE. This PR adds a main method to Runner.java to resolve this issue.

  2. Warnings Regarding Optional Usage: There were warnings related to the usage of Optional as a type for the id field in the classes CakeInfo, CakeLayerInfo, and CakeToppingInfo. The use of Optional for fields is generally discouraged, as Optional is primarily intended for method return types where there is a need to represent "no result" without using null.

I'm relatively new to contributing and may have misunderstood or not fully addressed the issues. If there are any mistakes or if further changes are needed, please let me know. Apologies for any inconvenience caused.

Copy link

sonarcloud bot commented May 5, 2024

@iluwatar
Copy link
Owner

iluwatar commented May 6, 2024

Let me know when it's ready for review

@romannimets romannimets marked this pull request as ready for review May 6, 2024 07:40
Copy link

stale bot commented Jun 5, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the status: stale issues and pull requests that have not had recent interaction label Jun 5, 2024
iluwatar
iluwatar previously approved these changes Jun 6, 2024
@stale stale bot removed the status: stale issues and pull requests that have not had recent interaction label Jun 6, 2024
@iluwatar
Copy link
Owner

iluwatar commented Jun 6, 2024

Sorry, I have missed the notification that this PR is ready for review. If you could fix the conflicts then we are ready to merge @romannimets

Copy link

sonarcloud bot commented Jun 9, 2024

@romannimets
Copy link
Contributor Author

Sorry @iluwatar i may have made some mistakes during the conflict solving process 😅, i hope now everything is all right. Thaks for the patience

@iluwatar iluwatar merged commit a27e092 into iluwatar:master Jun 15, 2024
2 checks passed
@iluwatar
Copy link
Owner

Looks good! Thank you for the contribution 🎉

@all-contributors please add @romannimets for code

Copy link
Contributor

@iluwatar

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

I've put up a pull request to add @romannimets! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants