Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix:added code refactoring changes for 2378 #2379

Merged
merged 6 commits into from
Dec 10, 2022
Merged

fix:added code refactoring changes for 2378 #2379

merged 6 commits into from
Dec 10, 2022

Conversation

Ap284
Copy link
Contributor

@Ap284 Ap284 commented Dec 2, 2022

Pull request title

  • Clearly and concisely describes what it does
  • Refer to the issue that it solves, if available

Pull request description

  • Describes the main changes that come with the pull request
  • Any relevant additional information is provided

For detailed contributing instructions see https://github.com/iluwatar/java-design-patterns/wiki/01.-How-to-contribute

iluwatar
iluwatar requested changes Dec 4, 2022
View reviewed changes
collection-pipeline/pom.xml Outdated
Comment on lines 60 to 67
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<configuration>
<source>16</source>
<target>16</target>
</configuration>
</plugin>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now set in the parent pom.xml. Please rebase your changes on top of master. Let's see if we get a passing build.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have the same configuration elsewhere too. Please check throughout the code.

@Ap284 Ap284 requested a review from iluwatar December 5, 2022 06:43
@iluwatar
Copy link
Owner

iluwatar commented Dec 5, 2022

Please try to address the failing build

iluwatar
iluwatar requested changes Dec 5, 2022
View reviewed changes
Copy link
Owner

@iluwatar iluwatar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build needs to pass before we can merge

@Ap284
Copy link
Contributor Author

Ap284 commented Dec 9, 2022 •
edited
Loading

Hi @iluwatar,

I have sync the fork with the upstream master branch. But, still getting the same issue:

Failed to execute goal org.sonarsource.scanner.maven:sonar-maven-plugin:3.8.0.2131:sonar (default-cli) on project java-design-patterns: Project not found. Please check the 'sonar.projectKey' and 'sonar.organization' properties, the 'SONAR_TOKEN' environment variable, or contact the project administrator -> [Help 1]

Please, guide me if I missed anything or incorrect.

@iluwatar
Copy link
Owner

The build works for me locally, so I don't think there's anything wrong in this branch. I recently reconfigured the Sonar scan, but maybe it's using the old one from the cache or something like that. Anyway, I'm going to merge this.

@iluwatar iluwatar merged commit 147e2e6 into iluwatar:master Dec 10, 2022
@iluwatar
Copy link
Owner

@all-contributors please add @Ap284 for code

@allcontributors allcontributors bot mentioned this pull request Dec 10, 2022
Merged
@allcontributors
Copy link
Contributor

@iluwatar

I've put up a pull request to add @Ap284! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iluwatar iluwatar iluwatar approved these changes

Assignees
No one assigned
Labels
status: under review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ap284 @iluwatar