Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Amendments to factory-kit README.md #2305

Merged
merged 1 commit into from
Nov 16, 2022
Merged

Amendments to factory-kit README.md #2305

merged 1 commit into from
Nov 16, 2022

Conversation

murphShaw
Copy link
Contributor

Updated README for the factory-kit pattern.

  • As established via Gitter, the README was in fact close to completion.
  • Despite the state of the README I made some trivial additions to help users.
  • This pattern was outlined in issue Explanation for design patterns #590 and regardless of the status of this PR, the pattern should be removed from the issue given its quality as established on Gitter.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@iluwatar iluwatar self-assigned this Nov 16, 2022
@iluwatar iluwatar added this to the 1.26.0 milestone Nov 16, 2022
@iluwatar iluwatar merged commit dc0afb8 into iluwatar:master Nov 16, 2022
@iluwatar
Copy link
Owner

Thank you for the improvements!

@all-contributors please add @murphShaw for docs

@allcontributors allcontributors bot mentioned this pull request Nov 16, 2022
Merged
@allcontributors
Copy link
Contributor

@iluwatar

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

I've put up a pull request to add @murphShaw! 🎉

iluwatar pushed a commit that referenced this pull request Nov 29, 2022
@murphShaw @iluwatar
docs: Amendments to factory-kit README (#2305)
71ce46e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iluwatar iluwatar iluwatar approved these changes

Assignees

@iluwatar iluwatar

Labels
status: under review
Projects
None yet
Milestone
1.26.0
Development

Successfully merging this pull request may close these issues.
2 participants
@murphShaw @iluwatar