Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed pages showing up in wrong language #1752

Merged
merged 4 commits into from
May 19, 2021
Merged

Fixed pages showing up in wrong language #1752

merged 4 commits into from
May 19, 2021

Conversation

JackieNim
Copy link
Contributor

Better PR of #1750

@JackieNim JackieNim mentioned this pull request May 11, 2021
Closed
@ohbus
Copy link
Contributor

ohbus commented May 11, 2021

Please continue with #1750

It is very difficult and time-consuming to review the same files again.

@ohbus ohbus closed this May 11, 2021
@ohbus ohbus self-assigned this May 11, 2021
@ohbus
Copy link
Contributor

ohbus commented May 11, 2021

@JackieNim reopen #1750 and push commits that you want to rectify.

Thank you.

@JackieNim
Copy link
Contributor Author

JackieNim commented May 11, 2021 •
edited
Loading

@JackieNim reopen #1750 and push commits that you want to rectify.

Thank you.

@ohbus I kinda deleted that fork so im not sure if I can do that :(

@ohbus
Copy link
Contributor

ohbus commented May 11, 2021

@JackieNim reopen #1750 and push commits that you want to rectify.
Thank you.

@ohbus I kinda deleted that fork so im not sure if I can do that :(

It takes time to review 180+ files.

Please try to reopen that PR and connect the fork.

@JackieNim
Copy link
Contributor Author

@JackieNim reopen #1750 and push commits that you want to rectify.
Thank you.

@ohbus I kinda deleted that fork so im not sure if I can do that :(

It takes time to review 180+ files.

Please try to reopen that PR and connect the fork.

Yeah it wont let me reopen it since the repo was deleted

@iluwatar iluwatar added this to the 1.25.0 milestone May 14, 2021
@JackieNim JackieNim mentioned this pull request May 14, 2021
Closed
@iluwatar iluwatar reopened this May 16, 2021
iluwatar
iluwatar requested changes May 16, 2021
View reviewed changes
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@iluwatar iluwatar merged commit f597fc1 into iluwatar:master May 19, 2021
@iluwatar
Copy link
Owner

Many thanks @JackieNim for the fix

RobbiNespu pushed a commit to RobbiNespu/java-design-patterns that referenced this pull request Mar 1, 2022
@JackieNim @RobbiNespu
fix: Fixed pages showing up in wrong language (iluwatar#1752)
9f39651 
* Fix languages

* Missed change for version number

* Add language field for presentation

* Revert change in README for double buffer

Co-authored-by: Jackie Nim <=>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iluwatar iluwatar iluwatar approved these changes

Assignees

@ohbus ohbus

Labels
status: under review
Projects
None yet
Milestone
1.25.0
Development

Successfully merging this pull request may close these issues.
3 participants
@JackieNim @ohbus @iluwatar