#1037: Fix error when building from a submodule directory #1045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add directory-maven-plugin to resolve the location of the license-plugin-header-style.xml from a submodule directory
iluwatar
approved these changes
Oct 26, 2019
|
Many thanks for solving this problem for us @vanogrid. Maven really does not make it easy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1037
The license-plugin-header-style.xml in the root directory was not resolved correctly when the project was built from a submodule directory, so I ended up adding a new plugin
directory-maven-pluginwhich does that.Other solutions were to use the
${maven.multiModuleProjectDirectory}property, but I was not able to make it work, or to add a relative path property to each of the submodules<properties><projectRoot>${parent.basedir}</projectRoot></properties>, but this configuration would be difficult to maintain, as there are 120 submodules.