Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update creating mechanism. #1

Merged
merged 11 commits into from
Sep 9, 2014
Merged

Update creating mechanism. #1

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
0509e48
Update IvoryTower.java
yusufaytas Sep 6, 2014
1f0bedb
double-checked-locking pattern is added.
yusufaytas Sep 6, 2014
459b696
Update pom.xml
yusufaytas Sep 6, 2014
3d55749
Update IvoryTower.java
yusufaytas Sep 6, 2014
c26ba60
Added Double Checked Locking to documentation.
yusufaytas Sep 7, 2014
c0c9028
Added class diagram to double checked locking.
yusufaytas Sep 7, 2014
8fb4d32
Added cases to use double-checked-locking.
yusufaytas Sep 7, 2014
91a7980
Added simple attributes to the Item.
yusufaytas Sep 7, 2014
2552d1b
Merge branch 'master' of github.com:yusufaytas/java-design-patterns
yusufaytas Sep 7, 2014
d6aed14
removed the lazy instantiation from singleton to avoid threading
yusufaytas Sep 7, 2014
d1e1be1
Added Intent to the Double Checked Locking.
yusufaytas Sep 8, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Update IvoryTower.java
  • Loading branch information
@yusufaytas
yusufaytas committed Sep 6, 2014
commit 0509e48d37d981ccdf60b252a263af561f0f08a0
8 changes: 5 additions & 3 deletions singleton/src/main/java/com/iluwatar/IvoryTower.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,14 @@
*/
public class IvoryTower {

private static IvoryTower instance = new IvoryTower();
private static IvoryTower instance;

private IvoryTower() {
}
private IvoryTower() {}

public static IvoryTower getInstance() {
if(instance == null){
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lazy initialization of the object introduces concurrent access problem (the access to the singleton object is not thread safe anymore).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh ok, I can avoid that with locking but it's not super important though. :) I'll skip this update.

instance = IvoryTower();
}
return instance;
}
}