Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapter needs better example #292

Closed
iluwatar opened this issue Nov 16, 2015 · 2 comments
Closed

Adapter needs better example #292

iluwatar opened this issue Nov 16, 2015 · 2 comments

Comments

@iluwatar
Copy link
Owner

The Adapter example kind of sucks and needs a more descriptive implementation. For inspiration these are quite good:

http://www.journaldev.com/1487/adapter-design-pattern-in-java-example-tutorial
http://www.tutorialspoint.com/design_pattern/adapter_pattern.htm

@JuhoKang
Copy link
Contributor

May I work on this issue?
Q: I found that the original example is based on the "Object Adapter Pattern" and there is an alternative which is the "Class Adapter Pattern". Which would be the better?
Should I just change example (names of the Objects?) and description or else?

@iluwatar
Copy link
Owner Author

Hi @JuhoKang it's great that you can work on this. It would be ideal to show both object adapter and class adapter in the example. Look at the links I gave above to get the idea what kind of example would be good. You can use the existing example as a base and just modify it as needed.

JuhoKang added a commit to JuhoKang/java-design-patterns that referenced this issue Dec 1, 2015
JuhoKang added a commit to JuhoKang/java-design-patterns that referenced this issue Dec 2, 2015
iluwatar added a commit that referenced this issue Dec 8, 2015
@iluwatar iluwatar added this to the 1.9.0 milestone Dec 8, 2015
@iluwatar iluwatar closed this as completed Dec 8, 2015
pratigya0 pushed a commit to pratigya0/java-design-patterns that referenced this issue Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants