Added pre-installed images #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to reduce time consumed to deploy container. Unfortunately only php-fpm and nginx were added, mysql wasn't added because its huge size. In future I'm gonna try to bypass those issues related to constant time consumers
ilolm
commented
Nov 4, 2024
|
|
||
| dockerd & | ||
| /usr/sbin/sshd -D | ||
| # Starting docker daemon + starting ssh daemon |
|
|
||
| # Adding images | ||
| docker image load -i /docker-images/nginx.tar | ||
| docker image load -i /docker-images/php-fpm.tar |
There was a problem hiding this comment.
loading php-fpm image into docker engine
|
To-do: Manual testing required |
1. Added waiting for the docker engine to start.
ilolm
commented
Nov 5, 2024
| /usr/sbin/sshd -D > /dev/null 2>&1 & | ||
|
|
||
| # Waiting for docker engine to start (until 'docker info' returns non-zero exit-code sleep 1) | ||
| until docker info >/dev/null 2>&1; do sleep 1; done |
There was a problem hiding this comment.
Waiting for docker engine to start before loading the nginx image
| COPY ./docker-web /home/king/docker-web | ||
|
|
||
| # Copying php docker image | ||
| COPY ["./docker-images/php-fpm.tar", "/docker-images/"] |
There was a problem hiding this comment.
Copying the image inside the container
|
All the tests have passed successfully. Summation of changes:Added pre-installed php-fpm image.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to reduce time consumed to deploy container. Unfortunately only php-fpm and nginx were added, mysql wasn't added because its huge size. In future I'm gonna try to bypass those issues related to constant time consumers as well.