This repository was archived by the owner on Apr 20, 2020. It is now read-only.
[WIP] Token based cancellation #330
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is a rework of the cancellation mechanism of lazyflow.
It replaces cancellation calback propagation with
CancellationToken
mechanism (article about this concept)What's wrong with callbacks?
Given that lazyflow operators and APIs often used in unexpected places it's possible that anyone at any point can call cancel. With the cancellation token mechanism, only a parent request creator can cancel the request and will be notified about it.
Also it should reduce amount of created callbacks in graph, while we will share reference to parent cancellation token.
TODO