Skip to content

Conversation

@jdsmithsos
Copy link
Contributor

@jdsmithsos jdsmithsos commented Sep 3, 2025

Jira tickets:

https://ikmdev.atlassian.net/browse/IIA-2739
https://ikmdev.atlassian.net/browse/IIA-2741

Summary of changes:

  • refactored calls to the viewCalculator to catch Exception thrown, but still provide a String value to the menu is rendered and working

Before changes: view coordinate menu went into overridden mode, but was not rendered correctly and not working

After selecting the Development module to include. The menu is not rendered correctly where multiple items are checked and there isn't a Remove overrides menu item available.

image

After changes: view coordinate menu is now rendered and works correctly

Select Development module to include.

image

The view coordinate menu still works, with the Remove overrides menu item available.

image

…iew coordinate menu to still render and work
@jdsmithsos jdsmithsos marked this pull request as ready for review September 3, 2025 20:38
Copy link
Contributor

@carldea carldea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Please have @swaroopsalvi look at this too. Not sure getPreferred... does what we think it does with respect to language preferences. I think it is fine for now. :-).

@jdsmithsos jdsmithsos merged commit 7f701fa into ikmdev:main Sep 4, 2025
7 checks passed
@jdsmithsos jdsmithsos deleted the feature/finished/IIA-2739-2741-view-coord-menu-catch-viewcalc-exception branch September 4, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants