Add DateComboBox control to select stamps #703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carldea
approved these changes
Sep 2, 2025
Contributor
carldea
left a comment
carldea
left a comment
There was a problem hiding this comment.
Great work!
Looks good to me.
Contributor
|
@jperedadnr I approved, but I will update branch, merge. |
dholubek
requested changes
Sep 2, 2025
Contributor
dholubek
left a comment
dholubek
left a comment
There was a problem hiding this comment.
I just had one question
| date = SIMPLE_DATE_FORMAT.parse(time.selectedOptions().getFirst()); | ||
| } catch (ParseException e) { | ||
| throw new RuntimeException(e); | ||
| return Long.parseLong(time.selectedOptions().getFirst()); |
Contributor
There was a problem hiding this comment.
@jperedadnr is there a situation where this could be the string "Latest" and the parseLong will throw an exception?
Contributor
Author
There was a problem hiding this comment.
It is in a try-catch though, so if selectedOptions contains anything but a long timestamp, it will return -1L.
Before this PR a RTE was thrown for such case, but that should be handled in a better way. If the "Latest" string should be mapped to a specific long value (like Long.MAX_VALUE), then we should pass such value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time FilterOption.Option now uses long timestamp (as string), and not just a local date (as a string), in order to pass along the stamp selected by the user with the new comboBox: