Skip to content

Conversation

@jdsmithsos
Copy link
Contributor

Jira ticket: https://ikmdev.atlassian.net/browse/IIA-2729

Summary of changes:

  • In ViewMenuTask
    • Added check for selected for the Include wildcard CheckMenuItem
    • Added check for selected for the Exclude wildcard CheckMenuItem
    • If not checked, just rechecks the CheckMenuItem
    • If checked, then clears the Set property
  • Set and ListPropertyWithOverride.clear() - put the final clear() call into an else, because no reason to clear a newly created empty Set/List

Before changes: The wildcard menu item can be deselected

After changes: The wildcard menu item CANNOT be deselected

@jdsmithsos jdsmithsos marked this pull request as ready for review August 28, 2025 20:32
Copy link
Contributor

@dholubek dholubek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Copy link
Contributor

@carldea carldea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@carldea carldea merged commit 254a1d5 into ikmdev:main Aug 29, 2025
3 checks passed
@jdsmithsos jdsmithsos deleted the feature/finished/IIA-2729-dont-allow-deselection-of-include-or-exclude-module-wildcard branch September 3, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants