Skip to content

Eclipse-Collections-13.0.0 Update#681

Merged
OmOmofonmwan merged 9 commits intoikmdev:mainfrom
OmOmofonmwan:feature/AR-000-Eclipse-Collections-Update
Aug 28, 2025
Merged

Eclipse-Collections-13.0.0 Update#681
OmOmofonmwan merged 9 commits intoikmdev:mainfrom
OmOmofonmwan:feature/AR-000-Eclipse-Collections-Update

Conversation

@OmOmofonmwan
Copy link
Contributor

@OmOmofonmwan OmOmofonmwan commented Aug 26, 2025

  • Updated Eclipse-Collections references to 13.0.0
  • tinkar-core updated to 1.122.0
  • tinkar-composer updated to 1.10.0
  • Commented reference to coordinate since it is now located inside the entity module in tinkar-core

@OmOmofonmwan OmOmofonmwan marked this pull request as draft August 26, 2025 21:42
@carldea
Copy link
Contributor

carldea commented Aug 26, 2025

Nice upgrade of this amazing library. :-)
Can you have QA test the PR before we approve and merge?
We'll need a full regression. All transactions, inport/export and gitsync functionality rely on Eclipse collections.

Copy link
Contributor

@jonaromero86 jonaromero86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up on this Uyi.
I cloned your PR and Komet builds successfully with tinkar-core version 1.122.0, also my local version 1.123.0-SNAPSHOT with some code changes I made for IKDT-909.
Looking forward for this PR to be merged to main.

@OmOmofonmwan OmOmofonmwan marked this pull request as ready for review August 28, 2025 16:08
Copy link
Contributor

@carldea carldea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
If tested we can merge.

@OmOmofonmwan OmOmofonmwan merged commit 293d0ac into ikmdev:main Aug 28, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants