feature/finished/IIA-2440-language-selection-in-parent-causes-child-override

[jdsmithsos]

Jira tickets:

https://ikmdev.atlassian.net/browse/IIA-2440
https://ikmdev.atlassian.net/browse/IIA-2441

Summary of changes: modified ObservableViewNoOverride.baseCoordinateChangedListenersRemoved() to set the value of existing LanguageCoordinates, rather than create new LanguageCoordinates objects

Before change: Changing the Parent language causes child view coordinates to go into Overridden mode

Select Journal view coordinate language to Spanish then back to English.
Child goes into Overridden mode.

After change: Child view coordinates no longer go into Overridden mode

[swaroopsalvi]

@jdsmithsos ,
I will recommend to you to use Public id instead of UUID, since this is an array of ids, you might get a false negative.
Here is what I will recommend:

` for (LanguageCoordinate newLangCoord : newValue.languageCoordinates()) {
PublicId newPublicId = EntityService.get().getEntityFast(newLangCoord.getLanguageCoordinateUuid()).publicId();

        for (ObservableLanguageCoordinateBase observableLanguageCoordinateBase : this.languageCoordinates) {
            PublicId existingPublicId = EntityService.get().getEntityFast(observableLanguageCoordinateBase.getLanguageCoordinateUuid()).publicId();
            if (PublicId.equals(existingPublicId, newPublicId)) {
            ...
            ..
            }
        }
  }

`

[jdsmithsos]

PublicId existingPublicId = EntityService.get().getEntityFast(observableLanguageCoordinateBase.getLanguageCoordinateUuid()).publicId();
if (PublicId.equals(existingPublicId, newPublicId)) {

I'll try this, thanks

[jdsmithsos]

I couldn't get the pubicID check to work, so I changed the way that the value is set, using the same way that the ObservableViewWithOverride does, which just indexes through the list and sets based on the index

[jdsmithsos]

@swaroopsalvi There is not a parentID method available in LanguageCoordinate, which is why I am using the UUID

[swaroopsalvi]

Looks good.
Approved.

[dholubek]

looks good