Feature/finished/iia 2623 implement author attribution in concept window concept version form #674
Conversation
…ished/IIA-2623-Implement-Author-Attribution-in-Concept-Window-Concept-Version-Form # Conflicts: # kview/src/main/java/dev/ikm/komet/kview/mvvm/view/journal/JournalController.java
…uthor-Attribution-in-Concept-Window-Concept-Version-Form
kview/src/main/java/dev/ikm/komet/kview/mvvm/viewmodel/LoginViewModel.java
Show resolved
Hide resolved
swaroopsalvi
requested review from
aks8m,
bhharsh13,
carldea,
dholubek,
dukke and
jdsmithsos
There was a problem hiding this comment.
@swaroopsalvi I left a small remark.
Also I'm not sure but when the stamp form hasn't been changed yet should we show the last stamp author rather than the current logged in user.
For the date we show the last stamp date and only when there's a change in the form do we change the date, in this case to "Uncommited".
In other words only when there's a change in the form and it's ready to be submitted do we show the logged in user as the author... I had the idea this was the case, but I could be wrong.
Thanks!
kview/src/main/java/dev/ikm/komet/kview/mvvm/view/properties/StampAddController.java
Show resolved
Hide resolved
Makes sense. Fixed it. |
kview/src/main/java/dev/ikm/komet/kview/mvvm/viewmodel/StampViewModel2.java
Show resolved
Hide resolved
dukke
left a comment
dukke
left a comment
There was a problem hiding this comment.
Looks good to me, thanks Swaroop!
4 participants
Before Change:
After Change:
Online User:
Select DB
Login using KOMET user
