-
Notifications
You must be signed in to change notification settings - Fork 39
IIA-2515 View Coordinate - Add Functionality to Concept Window -> "Change path" #659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IIA-2515 View Coordinate - Add Functionality to Concept Window -> "Change path" #659
Conversation
…e/IIA-2515-concept-window-change-path
…e/IIA-2515-concept-window-change-path
…e/IIA-2515-concept-window-change-path
…e/IIA-2515-concept-window-change-path
…e/IIA-2515-concept-window-change-path
…e/IIA-2515-concept-window-change-path
| } | ||
| }); | ||
|
|
||
| // TODO attach a listener to the view properties to refresh screen when user changes the view coordinates e.g. language to spanish |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this still a todo, if not update the comment to document the code below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed the TODO section since it is already implemented
carldea
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thank you @bhharsh13
This was a very difficult ticket. I appreciate your patience.
…e/finished/IIA-2515-concept-window-change-path
|
Implemented the changes to fetch the latest committed EntityVersion. Validated on local by changing the StampFilter Path from Development module to Primordial and looks good. |
| setupComboBox(moduleComboBox, allModules); | ||
|
|
||
| // populate the current module and select it (e.g. 'SNOMED CT core module') | ||
| ConceptEntity currentModule = (ConceptEntity) stampEntity.module(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ConceptEntity currentModule = findByNid(moduleComboBox.items(), stampEntity.module().nid());
moduleComboBox.valueProperty().set(currentModule);
public ConceptEntity findByNid(List<ConceptEntity> items, nid) {
items.forEach( item -> {
if (item.nid() == nid) ) {
return item;
}
}
}There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the findByNid() for the Other Controllers and the details are reflected correctly on selecting edit FQN and edit OtherName.
@carldea , please help to review.
|
Synced the branch and validated the flows on local. Changes looks good hence merging the PR. |

Implemented View Coordinate - Add Functionality to Concept Window -> "Change path" - https://ikmdev.atlassian.net/browse/IIA-2515
Before Change:


After Change:
