Skip to content

Conversation

@bhharsh13
Copy link
Contributor

Implemented View Coordinate - Add Functionality to Concept Window -> "Change path" - https://ikmdev.atlassian.net/browse/IIA-2515

Before Change:
Before Fix
Change Filter

After Change:
StampFilter changepath fix

}
});

// TODO attach a listener to the view properties to refresh screen when user changes the view coordinates e.g. language to spanish
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still a todo, if not update the comment to document the code below.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed the TODO section since it is already implemented

Copy link
Contributor

@carldea carldea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you @bhharsh13
This was a very difficult ticket. I appreciate your patience.

@bhharsh13
Copy link
Contributor Author

bhharsh13 commented Aug 20, 2025

Implemented the changes to fetch the latest committed EntityVersion. Validated on local by changing the StampFilter Path from Development module to Primordial and looks good.
@carldea , please help to approve the PR.
image

@bhharsh13 bhharsh13 marked this pull request as ready for review August 20, 2025 17:54
setupComboBox(moduleComboBox, allModules);

// populate the current module and select it (e.g. 'SNOMED CT core module')
ConceptEntity currentModule = (ConceptEntity) stampEntity.module();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  
ConceptEntity currentModule = findByNid(moduleComboBox.items(), stampEntity.module().nid());
moduleComboBox.valueProperty().set(currentModule);



   public ConceptEntity findByNid(List<ConceptEntity> items, nid) {
    items.forEach( item -> {
        if (item.nid() == nid) ) {
            return item;
        }
    }
   }

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the findByNid() for the Other Controllers and the details are reflected correctly on selecting edit FQN and edit OtherName.
@carldea , please help to review.

image image

@bhharsh13 bhharsh13 requested a review from carldea August 20, 2025 21:43
@bhharsh13
Copy link
Contributor Author

Synced the branch and validated the flows on local. Changes looks good hence merging the PR.

@bhharsh13 bhharsh13 merged commit ee68729 into ikmdev:main Aug 21, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants