IIA-2613 fixed the discovered view coordinate coding errors #658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carldea
approved these changes
Aug 20, 2025
Contributor
carldea
left a comment
carldea
left a comment
There was a problem hiding this comment.
JD,
Excellent work! So glad you were able to jump in and understand view coordinates.
Contributor
|
@jdsmithsos Assuming you've updated, tested your branch you may want to move it out of draft mode. |
Contributor
Author
updated and tested |
jdsmithsos
deleted the
feature/finished/IIA-2613-fix-view-coordinate-coding-errors
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the view coordinate effort, it was discovered that there were coding errors that was causing problems within the Language coordinates.
I fixed those coding errors, which then fixed 5 defects with view coordinate propagation.
I thought it would be a good idea to analyze the rest of the view coordinate classes, to see if there are any additional coding errors.
And there are.
This is a DRAFT PR to communicate what I found, and to get feedback from the team about moving forward with these fixes to merge to the main branch.
There are two other changes that are not related, but need to be done as well, to streamline the prior changes that were made to ObservableViewBase and ObservableViewWithOverride. Actually, these two changes can be moved to a different PR if needed to not have any riders on the intent of this PR.
Before changes:
Coding errors discovered.
After changes:
Discovered coding errors fixed (hopefully)