Feature/finished/iia 2353 retrieve list of author concepts to select during login to komet

[swaroopsalvi]

No description provided.

[Copilot]

Pull Request Overview

This PR implements a login author feature that allows users to select from a list of author concepts during login to Komet. The implementation replaces a mock user selection system with a dynamic retrieval of author concepts from the system.

• Replaces hardcoded fake users with dynamic retrieval of author concepts from the USER concept hierarchy
• Implements proper MVVM pattern for the login author functionality with validation
• Updates UI event handlers from signupAction to signInAction for consistency

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
JournalWindowPreferences.java	Adds constant for author login window preferences
loginAuthor.fxml	Updates action method names from signup to sign-in for consistency
LoginAuthorViewModel.java	New view model implementing validation and data binding for author login
LoginAuthorController.java	Refactored to use MVVM pattern with dynamic author concept retrieval
AppPages.java	Updated to use proper MVVM loader and pass view properties to login controller

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[carldea]

Can you make an enum here?

   public enum LoginProperties {
          AUTHORS("authors"), 
          SELECTED_AUTHOR("selected author"),
          ...
          
        public final String name;
        LoginProperties(String name){
            this.name = name;
        }
        LoginProperties(){
            this.name = this.name();
        }
   }

Please create a constructor to add a friendly name. An example is shown here:
https://github.com/carldea/cognitive/blob/main/src/test/java/org/carlfx/cognitive/test/demo/AccountViewModel.java#L33-L50
Friendly error messages used in validation messages can use string interpolation if needed.
For example: validationResult.error("${%s} first character must be upper case.".formatted(FIRST_NAME));

[carldea]

Can the second parameter make use of the enum for SELECTED_AUTHOR.name()?

[carldea]

Can we just do a unidirectional bind?

[carldea]

Can we bind disableProperty() to view model's is

loginButton.disableProperty().bind(loginAuthorViewModel.invalidProperty());

[carldea]

Can we add the following?

loginAuthorViewModel.doOnChange(()->{
   loginAuthorViewModel.validate();
}, SELECTED_AUTHOR, PASSWORD);

A view model contain validators will be update the validation messages.
Assuming the submit or login button is bound to the view model's invalidProperty().

[carldea]

Looks good to me!