JPRO-162: Sign In User author, and App/WebApp refactoring #642
Conversation
to a shared class. Introduced pattern, on how to share logic between App and WebApp. Possible with the final target, to merge them together.
…Menu classes, and updating AppInterface methods for better modularity and maintainability.
…et and AppMenu getters, and streamline menu creation in AppMenu.
…ods, adding state retrieval in AppInterface, and improving menu setup in AppMenu.
… in AppMenu, removing redundant methods and enhancing code maintainability.
… login-user-list-integrated
…er-list-integrated # Conflicts: # application/src/main/java/dev/ikm/komet/app/App.java # application/src/main/java/dev/ikm/komet/app/WebApp.java
changed the fxml file to sign up when return is pressed for passwordfield and passwordtextfield
several capital letters changes and removes one unused variable
Changed comment format and removed newline
…pp-merge # Conflicts: # application/src/main/java/dev/ikm/komet/app/App.java # application/src/main/java/dev/ikm/komet/app/WebApp.java
|
@FlorianKirmaier wow really nice work! |
|
@FlorianKirmaier The build failed because the pom.xml version has been bumped up (from a recent release of Komet). Can you resolve it in your branch? |
|
@carldea Thank you for the positive feedback! |
We are working on the permission issue. We are still in the process of QA testing :-) |
carldea
left a comment
carldea
left a comment
There was a problem hiding this comment.
Looks great!
I will approve for now. Until the QA testing is finished I will merge this effort first (tomorrow).
The other PRs pending will be next to be merged.
3 participants
In this PR, we achieved two major improvements.
SignInPage:
The new LoginAuthorSelection page allows to select a user.
Currently, it’s using fake data. Later, it will use the real users from the database.
WebApp/App Merge:
We did this refactoring now to avoid integrating the new LoginPage twice. This gives a lot of improvements.
These changes don't alter anything functionally, but they provide numerous improvements.