Feature/finished/iia 2531 illegalstateexception caught to not display dialog

[jdsmithsos]

Jira ticket: https://ikmdev.atlassian.net/browse/IIA-2531

Summary of changes:

• Added try catch for IllegalStateException where this was occurring
  • FetchChildren
  • MultiParentGraphCell
  • MultiParentGraphCellSkin
  • MultiParentGraphViewController

Even with this change, there are still menu behavior issues that need to be addressed in separate tickets:

• Multiple items are checked in the Excluded menu, which I assume is being caused by no data for the module type
• e.g. Select Development, then select Primordial
• Both Development and Primordial are checked
• This occurs both before the change, and after the change

Before changes:

Select Exclude all.

The IllegalStateException dialog was being displayed.

And both "no exclusions" and "exclude all" are checked.

After changes:

The IllegalStateException dialog is no longer displayed.

And the "no exclusions" menu item is NOT checked. "exclude all" and the other module menu items are checked correctly.

[carldea]

Out of curiosity, why are we getting IllegalStateExceptions?
is there a way to check state before executing .isLeaf()? Just feel we are surrounding code in places to ignore exception. I'm fine with this solution, but i'm concerned if we are hiding the real problem.

Could we ask @jperedadnr if this is a good solution for now?

[jdsmithsos]

Yes, lets ask if this solution makes sense. We should know why the exceptions happen. Perhaps if the exception is valid a different dialog should be displayed with user readable text rather than the exception dialog.

[carldea]

I think we should go ahead and merge this fix, since the view coordinates is responsible for querying results. the result may not make sense to the TreeView. After a exclude modules filter option.

[carldea]

Looks good enough for now. We'll have to find out if it even makes sense using those filter options.