feature/finished/IIA-2455-stamp-exclusions-not-being-checked#626
Merged
jdsmithsos merged 1 commit intoikmdev:mainfrom Aug 6, 2025
Conversation
…field for the new value
jdsmithsos
requested review from
bhharsh13,
carldea,
dholubek,
dukke and
swaroopsalvi
jdsmithsos
deleted the
feature/finished/IIA-2455-stamp-exclusions-not-being-checked
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira ticket: https://ikmdev.atlassian.net/browse/IIA-2455
Summary of changes: The ObservableStampCoordinateWithOverride.baseCoordinateChangeListenerRemoved() method was copying the incorrect field for the excludedModuleSet. Changed to use the correct field excludedModuleNids.
Note that the data does not have Primordial or Sandbox, so an IllegalStateException occurs, which needs to be worked in a separate Bug ticket.
Before change: Excluded modules were not being checked correctly, and the check was not propagating to the child view coordinate menus.
After change:
Parent view coordinate menu with Development excluded (checked).
Child view coordinate menu with Development excluded (checked).