Sort search results by top component #579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jperedadnr
commented
Jul 16, 2025
| * @return a string | ||
| */ | ||
| private String getDescription(int nid) { | ||
| return navigator.getViewCalculator().getFullyQualifiedDescriptionTextWithFallbackOrNid(nid); |
Contributor
Author
There was a problem hiding this comment.
@carldea Wondering if this should be
return treeView.getNavigator().getViewCalculator().getDescriptionTextOrNid(nid);
instead?
Contributor
There was a problem hiding this comment.
good question. might be better as long as it's not null.
I have approved this PR, not sure if you have permission to merge. But I can merge it some time tomorrow. :-)
carldea
approved these changes
Jul 23, 2025
Contributor
carldea
left a comment
carldea
left a comment
There was a problem hiding this comment.
Looks good! Thank you @jperedadnr !
as always great work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and improve performance while scrolling and highlighting search results.