Feature/finished/iia 2051 autosave fix for reordering set #489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dukke
requested changes
May 27, 2025
Contributor
dukke
left a comment
dukke
left a comment
There was a problem hiding this comment.
I have one comment.
Thanks!
framework/src/main/java/dev/ikm/komet/framework/observable/ObservableSemanticVersion.java
Show resolved
Hide resolved
carldea
approved these changes
May 27, 2025
Contributor
There was a problem hiding this comment.
@swaroopsalvi Can you create another ticket for a better solution?
I will approve for now. Can you fix the merge conflicts and merge yourself?
…ished/IIA-2051-autosave-fix-for-reordering-set # Conflicts: # kview/src/main/java/dev/ikm/komet/kview/mvvm/view/genediting/SemanticFieldsController.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before editing Set:
Changed the order of set.:
Closed journal window AND
Reopened journal window:
Hit Submit, Semantic set change saved:
Reopened edit properties: New order is reflected:
