Feature/Finished/IIA-2063: [Toast] Create POC of Toast control#488
Merged
carldea merged 4 commits intoikmdev:mainfrom May 28, 2025
Merged
Conversation
dukke
requested review from
bhharsh13,
carldea,
dholubek,
jdsmithsos and
swaroopsalvi
Contributor
|
Great work as usual @dukke , |
Contributor
Author
carldea
approved these changes
May 27, 2025
Contributor
carldea
left a comment
carldea
left a comment
There was a problem hiding this comment.
Looks amazing!
Can we create a ticket to update its Javadoc documentation?
Contributor
Author
oh yes, good point, I forgot about Javadoc. I've created this ticket to track that: https://ikmdev.atlassian.net/browse/IIA-2068 |
swaroopsalvi
requested changes
May 27, 2025
kview/src/main/java/dev/ikm/komet/kview/mvvm/view/genediting/SemanticFieldsController.java
Outdated
Show resolved
Hide resolved
# Conflicts: # kview/src/main/java/dev/ikm/komet/kview/mvvm/view/genediting/SemanticFieldsController.java
Contributor
Author
|
@carldea @swaroopsalvi made the changes requested. Added javadoc and fixed a bug where the position of the Toast could be wrong sometimes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: https://ikmdev.atlassian.net/browse/IIA-2062
Confluence Page: https://ikmdev.atlassian.net/wiki/spaces/IIA/pages/897286145/Toast+Control
Video of the toast showing up after a Semantic has been created:
2025-05-26.22-38-11.mp4
Update:
Also fixes: