Feature/finished/iia 1993 negative number fix #469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dholubek
requested review from
bhharsh13,
carldea,
dukke,
jdsmithsos and
swaroopsalvi
and removed request for
dukke and
swaroopsalvi
carldea
approved these changes
May 16, 2025
Contributor
carldea
left a comment
carldea
left a comment
There was a problem hiding this comment.
Looks good to me.
We'll need to revisit this for an improved solution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://ikmdev.atlassian.net/browse/IIA-1993
The defect exists when you have a single digit negative number and trying to hit the backspace key from the right of the number will be stuck and not allow the user to delete it. This fix allows the user to continue that delete operation. It isn't perfect but it is an improvement