Feature/finished/iia 1952 edit coord concept in journal#465
Conversation
dholubek
requested review from
bhharsh13,
carldea,
dukke,
jdsmithsos and
swaroopsalvi
and removed request for
carldea,
dukke and
swaroopsalvi
dholubek
changed the title
dholubek
changed the title
| } | ||
|
|
||
| public DetailsController(UUID conceptTopic) { | ||
| public DetailsController(UUID conceptTopic, ViewProperties viewProperties) { |
There was a problem hiding this comment.
Can we pass item through the view model?
There was a problem hiding this comment.
yes... I will update it...
There was a problem hiding this comment.
@carldea actually can we do this refactoring after the demo? it affected the navigation from the description pencil icon
There was a problem hiding this comment.
yes. Please create a new ticket to refactor (clean up).
I will approve.
| .controller(new DetailsController(conceptTopic)) | ||
| .controller(new DetailsController(conceptTopic, viewProperties)) | ||
| .updateViewModel("conceptViewModel", viewModel -> | ||
| viewModel.setPropertyValue(CURRENT_JOURNAL_WINDOW_TOPIC, journalWindowTopic)); |
There was a problem hiding this comment.
Is there a difference between the conceptTopic & journalWindowTopic?
I prefer controllers to be empty constructors. JavaFX's makes values available in the initialize() method.
There was a problem hiding this comment.
If I recall correctly the concept topic is for the concept window only and for things that only affect the current concept window like editing its FQN, we don't want all open concept windows to listen for that. And the journal topic is for events inside the entire journal window like saving the concept itself so that a navigator can be refreshed.
There was a problem hiding this comment.
Makes sense.
I think the data passing (to constructor) was before Cognitive apis. We can pass in 'conceptTopic and viewProperties' in the updateViewModel() method.
Not sure but check and see if we need to call updateView( ... ). Another older mechanism to pass data to update the controller or view.
2 participants
https://ikmdev.atlassian.net/browse/IIA-1952
existing coordinate menu in the classic Komet Concept navigator
we are showing this with from the bulls-eye onward to match the bulls-eye that is in the Concept's window title bar
NOTE the menu is display only
apologies for the large diff on concept-details.fxml... this appears to be SceneBuilder formatting on save