IIA-1971 New Path added in STAMP Module #464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e/IIA-1971-new-path-stamp-module
…e/IIA-1971-new-path-stamp-module
bhharsh13
requested review from
carldea,
dholubek,
dukke,
jdsmithsos and
swaroopsalvi
swaroopsalvi
requested changes
May 14, 2025
Contributor
swaroopsalvi
left a comment
swaroopsalvi
left a comment
There was a problem hiding this comment.
Can you also update the following methods in StampVeiwModel to call the fetchDescendentsOfConcets?
- findAllModules
- findAllPaths
So the body of the methods will be:
public Set findAllModules(ViewProperties viewProperties) {
return DataModelHelper.fetchDescendentsOfConcept(viewProperties, TinkarTerm.MODULE.publicId());
}
public Set findAllPaths(ViewProperties viewProperties) {
return DataModelHelper.fetchDescendentsOfConcept(viewProperties, TinkarTerm.PATH.publicId());
}
You will have to test all the screens including LIDR.
@carldea , This will have consistent implementation across all the dropdowns.
Please suggest.
swaroopsalvi
approved these changes
May 15, 2025
Contributor
swaroopsalvi
left a comment
swaroopsalvi
left a comment
There was a problem hiding this comment.
Looks good. Need to do unit testing for the modules that call these methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the issue for the new Path added in the STAMP Module.
https://ikmdev.atlassian.net/browse/IIA-1971
Validated the changes on local and looks good.
Please help to review the PR.