Feature/finished/iia 1933 last commit vals #440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dholubek
requested review from
bhharsh13,
carldea,
dukke,
jdsmithsos and
swaroopsalvi
and removed request for
swaroopsalvi
carldea
reviewed
May 8, 2025
kview/src/main/java/dev/ikm/komet/kview/events/genediting/GenEditingEvent.java
Outdated
Show resolved
Hide resolved
Contributor
swaroopsalvi
left a comment
swaroopsalvi
left a comment
There was a problem hiding this comment.
The reset / cancel / clear functionality is not required.
kview/src/main/java/dev/ikm/komet/kview/events/genediting/GenEditingEvent.java
Show resolved
Hide resolved
kview/src/main/java/dev/ikm/komet/kview/mvvm/view/genediting/SemanticFieldsController.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://ikmdev.atlassian.net/browse/IIA-1933
the observable fields that send over the event bus will revert (all except the string on Tinkar example 1 data) to their default values after the first iteration of the for loop in GenEditingDetailsController when updating the left side's real observable fields. I changed this to send plain objects instead.
edit window before editing:
edit window before submit:
edit window after submit:
re-summon window after submit:
