Feature/finished/iia 1529 drop line below title #406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the 0th position
merge from main
…ps://github.com/jdsmithsos/komet into feature/finished/IIA-1529-drop-line-below-title
…bel for the horizontal spacing below the label
…hen over the drop line area
jdsmithsos
requested review from
bhharsh13,
carldea,
dholubek,
dukke and
swaroopsalvi
dukke
approved these changes
Apr 29, 2025
Contributor
dukke
left a comment
dukke
left a comment
There was a problem hiding this comment.
Nice work! Looks good to me just had a small nitpick comment that is of something that's not even part of your PR.
| @@ -306,7 +323,21 @@ protected void layoutChildren(double contentX, double contentY, double contentWi | |||
| double x = contentX + padding.getLeft(); | |||
| double y = contentY + padding.getTop(); | |||
| titleLabel.resizeRelocate(x, y, labelPrefWidth, labelPrefHeight); | |||
Contributor
There was a problem hiding this comment.
This isn't part of your PR and it's a small nitpick but can you rename labelPrefWidth and labelPrefHeight to titlePrefWidth and titlePrefHeight?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket:
https://ikmdev.atlassian.net/browse/IIA-1529
Summary of changes:
Before changes:
Both the component dashed rectangle and drop line are shown
No top dropLine
After changes:
Drop line is not displayed when the component is highlighted during DnD
Top dropLine is now available for DnD
After drop at top dropLine