IIA-1578 Disable the edit the Reference Component of an existing semantic #377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhharsh13
requested review from
carldea,
dholubek,
dukke,
jdsmithsos and
swaroopsalvi
dholubek
requested changes
Apr 14, 2025
Contributor
dholubek
left a comment
dholubek
left a comment
There was a problem hiding this comment.
had a code styling comment
kview/src/main/java/dev/ikm/komet/kview/mvvm/view/genediting/GenEditingDetailsController.java
Outdated
Show resolved
Hide resolved
…e/finished/IIA-1578-disable-reference-component-pencil-icon
…component-pencil-icon
dukke
requested changes
Apr 14, 2025
Contributor
dukke
left a comment
dukke
left a comment
There was a problem hiding this comment.
Looks good just thought we can make one change to make it sligthly more readable (added a comment on that).
kview/src/main/java/dev/ikm/komet/kview/mvvm/view/genediting/GenEditingDetailsController.java
Outdated
Show resolved
Hide resolved
…e/finished/IIA-1578-disable-reference-component-pencil-icon
…encil-icon' of https://github.com/bhharsh13/komet into feature/finished/IIA-1578-disable-reference-component-pencil-icon
…component-pencil-icon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the fix for disabling the edit the Reference Component of an existing semantic once that semantic has been submitted. PR is under review.
Validated implementation on local and changes looks good.
PFA for reference.