Skip to content

IIA-1484 Create Properties Panel Page to Add Reference Component When Creating Semantic#335

Merged
dholubek merged 10 commits intoikmdev:mainfrom
bhharsh13:feature/finished/IIA-1484-add-reference-component-1
Mar 25, 2025
Merged

IIA-1484 Create Properties Panel Page to Add Reference Component When Creating Semantic#335
dholubek merged 10 commits intoikmdev:mainfrom
bhharsh13:feature/finished/IIA-1484-add-reference-component-1

Conversation

@bhharsh13
Copy link
Contributor

@bhharsh13 bhharsh13 commented Mar 21, 2025

Implemented Create Properties Panel Page to Add Reference Component When Creating Semantic
https://ikmdev.atlassian.net/browse/IIA-1484

  1. Given that I am creating a new semantic, when I click the Reference Component pencil icon, the Properties Panel should be opened (focused on Add/Edit) and I should see the label “Reference Component” with an empty search field.
    2.Given that I see the empty search field in the Properties Panel, I should be able to drag/drop the concept I want to add into the Search field.

Regarding save implementation we are checking with Andrew in Architect hours meet.

Validated the changes on my local and the changes looks good.
image
image
image

Copy link
Contributor

@swaroopsalvi swaroopsalvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have few minor comments.

Copy link
Contributor

@dholubek dholubek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bhharsh13 we should fix the component text issue before submitting a PR

@dukke
Copy link
Contributor

dukke commented Mar 23, 2025

Nice work @bhharsh13 !
On the first screen it's showing a Concept "Transitive Feature" on the left and nothing on the right...
@dholubek @swaroopsalvi @carldea correct me if I'm wrong but I think in principle that shouldn't be possible (once a reference component has been set it can't be changed) or is that going to be handled in a different ticket.

One other minor comment is: would it be possible to show the part of the screen that has the buttons at the bottom (I suppose you're not able to show the whole screen because your monitor is too small?)

@dholubek dholubek self-requested a review March 24, 2025 13:01
@dholubek
Copy link
Contributor

@bhharsh13 we should fix the component text issue before submitting a PR

original screenshot had the wrong component with drag and drop. this is working

@dholubek dholubek dismissed their stale review March 24, 2025 13:02

tested this locally and it is working; the issue was the wrong concept being dragged

@dholubek
Copy link
Contributor

Nice work @bhharsh13 ! On the first screen it's showing a Concept "Transitive Feature" on the left and nothing on the right... @dholubek @swaroopsalvi @carldea correct me if I'm wrong but I think in principle that shouldn't be possible (once a reference component has been set it can't be changed) or is that going to be handled in a different ticket.

One other minor comment is: would it be possible to show the part of the screen that has the buttons at the bottom (I suppose you're not able to show the whole screen because your monitor is too small?)

@dukke this ticket doesn't handle save. So I think the limitation of one reference component post save will be handled after save is handled.

Copy link
Contributor

@swaroopsalvi swaroopsalvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bhharsh13 , Just have few questions regarding the screenshots,

  1. I am sure you tested it but how come I see
image

Transitive feature on left and blank on the right, shouldn't it should transitive feature on the right? Unless the value on the left says place holder, the value on the right should reflect the value on the left. This is true in case of Creating semantic only, else the user should not be able to edit the reference component.

  1. Another observation is that the 2nd screenshot STAMP does not match with the 1st one.
image

@swaroopsalvi
Copy link
Contributor

Nice work @bhharsh13 ! On the first screen it's showing a Concept "Transitive Feature" on the left and nothing on the right... @dholubek @swaroopsalvi @carldea correct me if I'm wrong but I think in principle that shouldn't be possible (once a reference component has been set it can't be changed) or is that going to be handled in a different ticket.
One other minor comment is: would it be possible to show the part of the screen that has the buttons at the bottom (I suppose you're not able to show the whole screen because your monitor is too small?)

@dukke this ticket doesn't handle save. So I think the limitation of one reference component post save will be handled after save is handled.

@dukke , IMO the suer should be able to edit the reference component in create mode, even if it is submitted ? So I am in create mode and I create the reference component for the semantic, then I want to change it since I realized that I made a mistake in creation (I have not submitted/saved) the data. But even If I have have submitted the data and not published it yet, I should be able to edit it.
This is something we should ask Functional lead or Keith.

@swaroopsalvi swaroopsalvi self-requested a review March 24, 2025 13:59
@bhharsh13
Copy link
Contributor Author

Nice work @bhharsh13 ! On the first screen it's showing a Concept "Transitive Feature" on the left and nothing on the right... @dholubek @swaroopsalvi @carldea correct me if I'm wrong but I think in principle that shouldn't be possible (once a reference component has been set it can't be changed) or is that going to be handled in a different ticket.

One other minor comment is: would it be possible to show the part of the screen that has the buttons at the bottom (I suppose you're not able to show the whole screen because your monitor is too small?)

@bhharsh13 bhharsh13 closed this Mar 24, 2025
@bhharsh13 bhharsh13 reopened this Mar 24, 2025
@bhharsh13
Copy link
Contributor Author

bhharsh13 commented Mar 24, 2025

@swaroopsalvi , The screenshots attached were from different timings. We have defect to make the edit reference component to be disabled in next sprint. The current functionality is create mode for adding new reference component. If you see the Acceptance criteria for the defect- In this defect we are adding a field for reference component.

  1. Given that I am creating a new semantic, when I click the Reference Component pencil icon, the Properties Panel should be opened (focused on Add/Edit) and I should see the label “Reference Component” with an empty search field.
  2. Given that I see the empty search field in the Properties Panel, I should be able to drag/drop the concept I want to add into the Search field.

updated the screenshots in the PR. Please check if this looks good.

@bhharsh13
Copy link
Contributor Author

bhharsh13 commented Mar 24, 2025

Hi @dukke ,
We have defect to make the edit reference component to be disabled in next sprint. The current functionality is create mode for adding new reference component. In the current defect, on clicking the edit function we are opening the property bump out adding new reference component and drag drop the reference component.
Save/Cancel/Clear function will be addressed in other stories of upcoming sprint.
Please check the acceptance criteria

@dholubek
Copy link
Contributor

@swaroopsalvi , The screenshots attached were from different timings. We have defect to make the edit reference component to be disabled in next sprint. The current functionality is create mode for adding new reference component. If you see the Acceptance criteria for the defect- In this defect we are adding a field for reference component.

  1. Given that I am creating a new semantic, when I click the Reference Component pencil icon, the Properties Panel should be opened (focused on Add/Edit) and I should see the label “Reference Component” with an empty search field.
  2. Given that I see the empty search field in the Properties Panel, I should be able to drag/drop the concept I want to add into the Search field.

updated the screenshots in the PR. Please check if this looks good.

@bhharsh13 @swaroopsalvi for 1) we should ask at the end of stand up or in team chat if the reference component [place holder] on the left for new semantic is in scope for this story. I see what @swaroopsalvi is talking about and it and it doesn't say placeholder for creating a new one, but not sure if it is in scope

for 2) I'm not sure if we are comparing the create semantic vs edit semantic screens with the stamp area @swaroopsalvi. We might need a meeting to go over that because I don't follow what you are comparing. When I run her branch locally the create shows an empty stamp and that is what it should do.

Copy link
Contributor

@dholubek dholubek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@dholubek dholubek merged commit 7ec50ff into ikmdev:main Mar 25, 2025
6 checks passed
jlgrock pushed a commit to jlgrock/komet that referenced this pull request Apr 3, 2025
… Creating Semantic (ikmdev#335)

* Update version to start feature: IIA-1484-add-reference-component-1

* add Reference component details

* Update version to finish feature: IIA-1484-add-reference-component-1

* updated the controller for binding the component field

* removed the commented code and unused imports

* add reference component field

---------

Co-authored-by: Doug Holubek <dholubek@users.noreply.github.com>
carldea pushed a commit that referenced this pull request Apr 7, 2025
* updating README and helping nexus run as well as a number of jpro fixes for docker.  Nexus runs behind the proxy, but I need to fix that for komet

* Fix some configuration to build and run Komet via JPro using docker

* Reverse nginx proxy configuration for `nexus` and `komet` services

* adjusting nginx file to work in docker compose

* Provide nginx proxy configuration for `komet` service running with JPro server

* Configure a default `users.ini` file required when running Komet on the web platform

* adjusting to use maven wrapper

* updates to use path based routing for komet web

* increasing font size

* updating some language and formatting on README

* Feature/finished/fixed null pointer for submit button enable disable (#326)

* null check added

* Feature/finished/jpro 109 fix exporting a file prompts the user to enter the file name twice (#321)

* Update version to start feature: jpro-109-fix-exporting-a-file-prompts-the-user-to-enter-the-file-name-twice

* Update JPro Platform dependencies to version `0.5.6`

* Update version to finish feature: jpro-109-fix-exporting-a-file-prompts-the-user-to-enter-the-file-name-twice

* Change to run reasoner (#328)

* Feature/finished/iia 1130 (#329)

* Update version to start feature: IIA-1130-try2

* initial commit

* Update version to finish feature: IIA-1130-try2

* code review fixes and hiding stamp when in create mode

* Feature/finished/iia 1648 data on the left side of semantic window reverts back to its previous value after user close and reopen the window (#330)

* Removed the code to reflect correct data.

* Removed commented code.

* Feature/finished/iia 1649 bugfix property bump genedit (#331)

* Update version to start feature: IIA-1649-bugfix-property-bump-genedit

* fix checks basically who invoked the window

* fixing poms

* Feature/finished/iia 1471 component default value (#333)

* Update version to start feature: IIA-1471-Component-Default-Value

* Feature/IIA-1471: Use "Placeholder" and Default Value for Undefined Component Field

* Update version to finish feature: IIA-1471-Component-Default-Value

* Better fix to submit and show uncommmitted transactions.

* Removed unnecessary code

* Feature/finished/iia 1417 new semantic from pattern window (#334)

* Update version to start feature: IIA-1417-new-semantic-from-pattern-window

* summon new semantic form context menu on pattern window

* Update version to finish feature: IIA-1417-new-semantic-from-pattern-window

* Feature/finished/iia 1579 semantic title (#336)

* Update version to start feature: IIA-1579-semantic-title

* update the title area text

* Update version to finish feature: IIA-1579-semantic-title

* using viewCalculator for the pattern's FQN

* Feature/finished/jpro 111 fix npe in popover ocurring randomly on show call (#337)

* Update version to start feature: jpro-111-fix-npe-in-popover-ocurring-randomly-on-show-call

* Update ControlsFX dependency to version `11.2.2`

* Update version to finish feature: jpro-111-fix-npe-in-popover-ocurring-randomly-on-show-call

* Feature/finished/iia 1408 new semantic no selection made (#338)

* Update version to start feature: IIA-1408-new-semantic-no-selection-made

* new semantic wording

* Update version to finish feature: IIA-1408-new-semantic-no-selection-made

* Update version to start feature: IIA-1589-concept-pattern-toggle

* IIA-1484 Create Properties Panel Page to Add Reference Component When Creating Semantic (#335)

* Update version to start feature: IIA-1484-add-reference-component-1

* add Reference component details

* Update version to finish feature: IIA-1484-add-reference-component-1

* updated the controller for binding the component field

* removed the commented code and unused imports

* add reference component field

---------

Co-authored-by: Doug Holubek <dholubek@users.noreply.github.com>

* Fixed Concepts Patterns toggle on double click

* Update version to finish feature: IIA-1589-concept-pattern-toggle

* moved the code to generic method

* Feature/finished/iia-1467 iia-1468 iia-1469 iia-1670 placeholder (#340)

* Update version to start feature: IIA-1467-IIA-1468-IIA-1469-IIA-1670-Placeholder

* Feature/IIA-1467, IIA-1468, IIA-1469, IIA-1470: Add placeholder feature to data types

* Update version to finish feature: IIA-1467-IIA-1468-IIA-1469-IIA-1670-Placeholder

* Feature/IIA-1467, IIA-1468, IIA-1469, IIA-1470: remove commented out code

---------

Co-authored-by: Doug Holubek <dholubek@users.noreply.github.com>

* IIA-1590 - Clear function implementation for Next gen search pane (#339)

* Update version to start feature: IIA-1590-search-concept

* Search textfield Clear function

* Update version to finish feature: IIA-1590-search-concept

* updated the cursor values for text and close button

---------

Co-authored-by: Doug Holubek <dholubek@users.noreply.github.com>

* Feature/finished/iia 1646 correct image check (#343)

* Update version to start feature: IIA-1646-Correct-Image-Check

* Feature/IIA-1646: Implementing Image check properly

* Update version to finish feature: IIA-1646-Correct-Image-Check

---------

Co-authored-by: Doug Holubek <dholubek@users.noreply.github.com>

* Update version to start feature: IIA-1471-Uncomment-code

* Feature/IIA-1471: Uncomment commented out code

* Update version to finish feature: IIA-1471-Uncomment-code

* Feature/IIA-1471: adding spaces in appropriate places

* Feature/finished/iia 1130 default values (#344)

* Update version to start feature: IIA-1130-default-values

* working for everything except reference component

* remove comment

* allow zero by itself while still disallowing leading zeros

* Update version to finish feature: IIA-1130-default-values

* Feature/finished/jpro 106 implement show more show less for other names (#342)

* Update version to start feature: jpro-106-implement-show-more-show-less-for-other-names

* Implement a custom control that displays a collapsible/expandable list of nodes with animated transitions

* Implement `Show More/Show Less` functionality for `Other Names` section using `KLExpandableNodeListControl`. Revise Descriptions section layout/styling to align with Figma designs.

* Update version to finish feature: jpro-106-implement-show-more-show-less-for-other-names

* Some cleanup

* Change background color from `-Grey-White` to standard `white` for codebase consistency

* Feature/finished/jpro 118 standardize semantic window backgrounds remove bottom insets (#346)

* Update version to start feature: jpro-118-standardize-semantic-window-backgrounds-remove-insets

* Remove the opacity property from the parent container to ensure the `white` background color renders correctly in each section of the Semantic windows

* Set the background color to `white` for the top section of all Semantic windows

* Remove the bottom inset from the last section of each Pattern, Lidr, and GenEditing window

* Update version to finish feature: jpro-118-standardize-semantic-window-backgrounds-remove-insets

* Feature/finished/iia 1645 reordering list submit (#347)

* Update version to start feature: IIA-1645-Reordering-List-Submit

* Feature/IIA-1645: Reordering a List is no longer enabling submit

* Update version to finish feature: IIA-1645-Reordering-List-Submit

* Feature/IIA-1645: When value changes write to database if submit button is enabled

* Feature/iia 1579 semantic title (#348)

* Update version to start feature: IIA-1579-semantic-title

* changing the title

* feature finish commit

* fixes

* fix typo

---------

Co-authored-by: Doug Holubek <dholubek@deloitte.com>

* Feature/finished/IIA-1655 AND IIA-1687 AND IIA-1626: set reordering  (#349)

* Update version to start feature: IIA-1655-Set-Reordering

* Feature/IIA-1655 AND IIA-1687: Update Tinker core and fix component set reordering issue

* Update version to finish feature: IIA-1655-Set-Reordering

* Feature/finished/iia 1684 component integer min value (#351)

* Update version to start feature: IIA-1684-Component-Integer-MinValue

* Feature/IIA-1684: When creating a semantic use Concept with Integer.MIN_VALUE for empty Components

* Feature/IIA-1684: Update version in POM files and remove feature branch words

* Update release version: 1.49.0

* Update development version: 1.50.0-SNAPSHOT

---------

Co-authored-by: Besmir Beqiri <besmir.beqiri@logicbind.io>
Co-authored-by: swaroopsalvi <67095791+swaroopsalvi@users.noreply.github.com>
Co-authored-by: Besmir Beqiri <bb@sandec.de>
Co-authored-by: Eric Mays <33882547+emays@users.noreply.github.com>
Co-authored-by: Doug Holubek <dholubek@users.noreply.github.com>
Co-authored-by: Pedro Duque Vieira <pedro.duquevieira@gmail.com>
Co-authored-by: swsalvi <swaroopsalvi@gmail.com>
Co-authored-by: bhharsh13 <bhavani.sreehari@gmail.com>
Co-authored-by: Indrit Beqiri <ib@sandec.de>
Co-authored-by: Doug Holubek <dholubek@deloitte.com>
Co-authored-by: ikmdevops <devops@ikm.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants