Skip to content

Feature/finished/fixed null pointer for submit button enable disable #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carldea merged 3 commits into from
Mar 19, 2025
Merged

Feature/finished/fixed null pointer for submit button enable disable #326

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e071ab5
Merge pull request #196 from ikmdev/main
swaroopsalvi Mar 17, 2025
f581f7f
null check added
swaroopsalvi Mar 19, 2025
e78b0cd
null check added
swaroopsalvi Mar 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions kview/src/main/java/dev/ikm/komet/kview/mvvm/view/genediting/SemanticFieldsController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,14 @@ public class SemanticFieldsController {

private int committedHash;

private void enableDisableSubmitButton(Object value){
if(value != null && !value.toString().isEmpty()) {
enableDisableSubmitButton();
}else {
submitButton.setDisable(true);
}
}

private void enableDisableSubmitButton(){
int uncommittedHash = calculteHashValue(observableFields);
submitButton.setDisable(committedHash == uncommittedHash);
Expand Down Expand Up @@ -126,8 +134,8 @@ private void initialize() {
editFieldsVBox.getChildren().clear();
observableFields.forEach(observableField -> {
observableField.valueProperty()
.addListener(observable -> {
enableDisableSubmitButton();
.subscribe(value -> {
enableDisableSubmitButton(value);
});
//Add listener for fieldProperty of each field to check when data is modified.
observableField.fieldProperty().addListener(observable -> fieldPropertyChangeListner());
Expand Down