Skip to content

Feature/finished/ikm kec kl8 #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
carldea merged 6 commits into from
Mar 7, 2025
Merged

Feature/finished/ikm kec kl8 #308

carldea merged 6 commits into from
Mar 7, 2025

Conversation

@kec
Copy link
Contributor

@kec kec commented Mar 6, 2025

Integrating Knowledge Layout with latest release.

Keith E Campbell and others added 6 commits March 6, 2025 01:15
Update version to start feature: IKM-KEC-KL8
7290e2a
@indritbeqiri
Guard identicon generation with non-null patternFacade check
596f432 
# Conflicts:
#	kview/src/main/java/dev/ikm/komet/kview/mvvm/view/pattern/PatternDetailsController.java
@indritbeqiri
Correct value name inside identifierText binding
d54f204 
# Conflicts:
#	kview/src/main/java/dev/ikm/komet/kview/mvvm/view/pattern/PatternDetailsController.java
Squashed commit of the following:
e86e2a6 
commit 2e2069d
Author: Keith E Campbell <rotors.snooty-0e@icloud.com>
Date:   Wed Mar 5 18:04:47 2025 -0800

    Naming changes to reduce overloaded terms…

    KlWindowPane -> KLFrame
    Kl*Pane -> Kl*Area (Controls such as ListView are not Panes, but Regions, chaning to term that is not overloaded)

commit c16fa86
Author: Keith E Campbell <rotors.snooty-0e@icloud.com>
Date:   Sun Mar 2 12:55:31 2025 -0800

    Implemented FieldLocator

commit 470a31e
Author: Keith E Campbell <rotors.snooty-0e@icloud.com>
Date:   Mon Feb 24 10:59:31 2025 -0800

    Documentation for immutable enum sets.

commit 25687cc
Author: Keith E Campbell <rotors.snooty-0e@icloud.com>
Date:   Mon Feb 24 10:48:22 2025 -0800

    Updates to try and nail down specification of observable fields.

commit 6e700c3
Author: Keith E Campbell <3868866+kec@users.noreply.github.com>
Date:   Fri Feb 21 15:01:08 2025 -0800

    Checkpoint

commit e56d848
Author: Keith E Campbell <rotors.snooty-0e@icloud.com>
Date:   Fri Feb 21 10:16:37 2025 -0800

    Pom updates to work with Java 23.

commit 4d14d54
Author: Keith E Campbell <rotors.snooty-0e@icloud.com>
Date:   Fri Feb 21 08:20:36 2025 -0800

    Bump version of tinkar.core.

commit c550682
Author: Keith E Campbell <rotors.snooty-0e@icloud.com>
Date:   Wed Feb 19 15:09:57 2025 -0800

    Added fill height and fill width to KlWidget.

commit 89a7fc7
Author: Keith E Campbell <rotors.snooty-0e@icloud.com>
Date:   Wed Feb 19 08:08:21 2025 -0800

    Updates to factory generics.

commit 2f48245
Author: Keith E Campbell <rotors.snooty-0e@icloud.com>
Date:   Tue Feb 18 19:33:05 2025 -0800

    Added missing layout properties for grid pane, and updated Generics for KlGenericFieldPane.

commit eb95031
Author: Keith E Campbell <rotors.snooty-0e@icloud.com>
Date:   Sun Feb 16 16:16:07 2025 -0800

    Clarification of generic naming (DT = DT, KL = Knowledge Layout, FX = fx component). Added stamp fields.

commit 67f63af
Author: Keith E Campbell <3868866+kec@users.noreply.github.com>
Date:   Fri Feb 14 15:39:03 2025 -0800

    Made ObservableEntity version property public.  Made context use UUID rather than string for identifier.

commit 18d9fef
Author: Keith E Campbell <rotors.snooty-0e@icloud.com>
Date:   Fri Feb 14 08:11:35 2025 -0800

    Checkpoint

commit 53e604f
Author: Keith E Campbell <rotors.snooty-0e@icloud.com>
Date:   Wed Feb 12 14:36:49 2025 -0800

    Update version to start feature: IKM-KEC-KL7
Update version to finish feature: IKM-KEC-KL8
73498cf
Changed tinkar-core.version to latest release.
2a979ac
@kec kec requested review from aks8m and carldea March 6, 2025 10:44
carldea
carldea approved these changes Mar 6, 2025
View reviewed changes
Copy link
Contributor

@carldea carldea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kec
It looks good to me. I approved the PR, but we should test the PR builds (github actions) before we merge to the main branch.

@kec
Copy link
Contributor Author

kec commented Mar 7, 2025

@kec It looks good to me. I approved the PR, but we should test the PR builds (github actions) before we merge to the main branch.

What is the timeline for testing the PR builds? Is it the java version upgrade that is adding this additional step?

@carldea
Copy link
Contributor

carldea commented Mar 7, 2025

@kec It looks good to me. I approved the PR, but we should test the PR builds (github actions) before we merge to the main branch.

What is the timeline for testing the PR builds? Is it the java version upgrade that is adding this additional step?

Really should be quick. QA will do a smoke test on the builds:

@kec It looks good to me. I approved the PR, but we should test the PR builds (github actions) before we merge to the main branch.

What is the timeline for testing the PR builds? Is it the java version upgrade that is adding this additional step?

Should be done in the next half hour. I will ping QA and find out.

@carldea carldea merged commit 60b3eeb into ikmdev:main Mar 7, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carldea carldea carldea approved these changes

@aks8m aks8m Awaiting requested review from aks8m

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kec @carldea @indritbeqiri