Skip to content

Conversation

@awesomejt-work
Copy link
Contributor

Java 23 Changes:

  • Update build parent to Java 23 compatible one
  • Latest tinkar core
  • Update GitHub actions for Java 23
  • Add enable preview to java.config file
  • Add enable preview to compile, surefire, and failsafe plugins
  • Remove legacy Jenkins files
  • Disable tests using mockito because of Java 23 compatibility issue

Copy link
Contributor

@dholubek dholubek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, we can just I think delete the commented out code in the pom.xml

</parent>
<artifactId>application</artifactId>
<dependencies>
<!--
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can probably remove this, as it is commented out and fixed by 1.87.0 of tinkar

@indritbeqiri
Copy link
Contributor

@awesomejt-work
Hi Jason,
Could you please review this Jira comment before disabling the tests in this PR related to the Java 23 update and Mockito issues? If you re-enable them they should pass successfully. This also applies to the tinkar-core tests disabled for the Java 23 update.
For reference, here’s the link to a branch from a forked Komet repository that builds successfully with these PR changes and with all tests enabled.

@indritbeqiri @besidev

Copy link
Contributor

@carldea carldea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA has run tests successfully using an updated dataset (database).
Database includes the newer luncene indexes.

Copy link
Contributor

@dholubek dholubek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@carldea carldea merged commit 209bf71 into ikmdev:main Mar 5, 2025
6 checks passed
@awesomejt-work awesomejt-work deleted the feature/finished/AR-299_Java23 branch March 5, 2025 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants