Skip to content

Feature/finished/iia 1335 numbered editable list#280

Merged
dukke merged 9 commits intoikmdev:mainfrom
dukke:feature/finished/IIA-1335-Numbered-Editable-List
Feb 26, 2025
Merged

Feature/finished/iia 1335 numbered editable list#280
dukke merged 9 commits intoikmdev:mainfrom
dukke:feature/finished/IIA-1335-Numbered-Editable-List

Conversation

@dukke
Copy link
Contributor

@dukke dukke commented Feb 22, 2025

# Conflicts:
#	application/pom.xml
#	artifact/pom.xml
#	builder/pom.xml
#	classification/pom.xml
#	details/pom.xml
#	executor/pom.xml
#	framework/pom.xml
#	knowledge-layout/pom.xml
#	komet-terms/pom.xml
#	kview/pom.xml
#	list/pom.xml
#	navigator/pom.xml
#	pom.xml
#	preferences/pom.xml
#	progress/pom.xml
#	rules/pom.xml
#	search/pom.xml
@carldea
Copy link
Contributor

carldea commented Feb 23, 2025

@dukke Pedro,
Really glad you have reordering with a green line working!
But I think there is a subtle difference in the way the figma spec. describes the scenarios. Also think the specification changed recently after your PR.

Let's confirm this together & design team. I was thinking of two option for this PR:

  1. We could merge your work (good enough for now) and create another ticket to make the changes based on the newer specs.
  2. We could continue to work on this PR (Put in draft) to follow the specs.

Notes:
Scenarios when reordering: ( A caveat - I could be completely wrong 👎🏼 : -)

  1. Last item to the first item - green line needs to be above the first item (appearing as an insert) pushing items down.
  2. First item or outside item dragged to the bottom. - green line needs to be below the last item pushing items up.
    Screenshot 2025-02-23 at 5 05 33 PM
    The above example shows the 5th item dragged to be the 2nd item.

Outstanding questions:

  1. Based on the above we should have more Figma example wireframes covering all scenarios.

  2. The figma specs shows a white blank background when dragging the item back in place.
    Screenshot 2025-02-23 at 5 09 40 PM

  3. We now have an addition 'X' beside the new item from the Add Entry button. Can we just have one?
    Screenshot 2025-02-23 at 5 13 50 PM

  4. In the figma specs why is the user allowed to add more than one blank field.
    Screenshot 2025-02-23 at 5 02 37 PM

@dukke
Copy link
Contributor Author

dukke commented Feb 24, 2025

@carldea Thanks for the detailed comments to this PR.

Notes:

1 - I think I understand what you're saying but there are practical reasons to why that doesn't happen on this PR. We don't have space between the title and the first component to draw a drop line there. We can add more space between the title and the first component but then we'll have to do that for every editable component for consistency's sake. Perhaps we could do that, but we might want to add another ticket as this one is already getting too big (it's already fixing 3 issues) and contains tickets there were target for the previous sprint.

2 - Not sure I understand this one but maybe we can talk in a video meeting...

Outstanding questions:

Those are good questions but maybe we can tackle them outside of this PR as this PR is already too big and also references tickets that were already in a previous sprint? So perhaps we finish or merge this (if we agree on how things are implemented and done) and then we can tackle other issues on a different ticket?

@carldea
Copy link
Contributor

carldea commented Feb 26, 2025

I agree it is getting large (taking too long) and changes in the Figma spec happened after your merge was created.

At least we have a working version. 👍🏻

@dukke dukke merged commit 80f2b43 into ikmdev:main Feb 26, 2025
6 checks passed
@dukke
Copy link
Contributor Author

dukke commented Feb 26, 2025

@carldea thanks for your valuable feedback. Just merged. I'm going to create tickets for your other comments so we can address those issues next.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants