Feature/finished/iia 1311 implement data validation error for integer control #275
Conversation
sync with main
Sync with main.
Sync with main
Sync with main
Sync with main
Sync with main
carldea
left a comment
carldea
left a comment
There was a problem hiding this comment.
Looks good to me! Thanks @swaroopsalvi
I will approve, however can we have @dukke review it just to make sure we aren't missing anything.
There was a problem hiding this comment.
Good work @swaroopsalvi ! 👍
Left a few comments.
I see that in the picture the error label is occupying 2 lines, I guess that there will probably be a jump on the other controls that are below because initially the control that is in error doesn't occupy that much space.
I think it'll probably be better if we try that the error label only occupies 1 line all the time so that there is no "jumping"...
kview/src/main/resources/dev/ikm/komet/kview/controls/integer-control.css
Show resolved
Hide resolved
kview/src/main/resources/dev/ikm/komet/kview/controls/integer-control.css
Show resolved
Hide resolved
@carldea I've reviewed the PR made a few comments. Thanks |
…idation-Error-for-Integer-Control
…ent-Data-Validation-Error-for-Integer-Control' into feature/finished/IIA-1311-Implement-Data-Validation-Error-for-Integer-Control
swaroopsalvi
deleted the
feature/finished/IIA-1311-Implement-Data-Validation-Error-for-Integer-Control
branch
5 participants
Uh oh!
There was an error while loading. Please reload this page.