Feature/finished/iia 1349 fix data refresh #246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dholubek
reviewed
Feb 4, 2025
| */ | ||
| public static void putArrowOnRight(TitledPane pane) { | ||
| putArrowOnRight(pane, DEFAULT_BUTTON_SPACING, ".title", ".arrow-button"); | ||
| //putArrowOnRight(pane, DEFAULT_BUTTON_SPACING, ".title", ".arrow-button"); |
Contributor
There was a problem hiding this comment.
do we want this commented out here or on the caller (GenEditingDetailsController::putTitlePanesArrowOnRight) in our controller because this will flip the position on other windows (eg Pattern) that use it.
Contributor
There was a problem hiding this comment.
Not sure why folks were getting a null pointer exception (selectors .arrow-button weren't added to the substructure of the title at the time of the call).
I thought we could resolve this another way later. Just wanted the refresh to work.
stenkarl
approved these changes
Feb 4, 2025
Contributor
stenkarl
left a comment
stenkarl
left a comment
There was a problem hiding this comment.
I also tested locally and it all looks good to me.
carldea
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Data refresh issue.
Validated locally to reflect the Data refresh functionality. Currently working on updating values into Database.
PFA for reference.
https://ikmdev.atlassian.net/browse/IIA-1349
Existing Semantic details
Editing new values
Data refresh on Semantic Details Panel after clicking "Submit".