Feature/finished/iia 1350 close prop panel#243
Merged
stenkarl merged 69 commits intoikmdev:mainfrom Feb 3, 2025
dholubek:feature/finished/IIA-1350-close-prop-panel
Merged
Feature/finished/iia 1350 close prop panel#243stenkarl merged 69 commits intoikmdev:mainfrom dholubek:feature/finished/IIA-1350-close-prop-panel
stenkarl merged 69 commits intoikmdev:mainfrom
dholubek:feature/finished/IIA-1350-close-prop-panel
Conversation
dholubek
requested review from
bhharsh13,
carldea,
dukke,
stenkarl and
swaroopsalvi
stenkarl
reviewed
Feb 3, 2025
kview/src/main/java/dev/ikm/komet/kview/mvvm/view/genediting/CloseProperitesController.java
Outdated
Show resolved
Hide resolved
…om:dholubek/komet into feature/finished/IIA-1350-close-prop-panel
dukke
reviewed
Feb 3, 2025
dukke
reviewed
Feb 3, 2025
| <RowConstraints minHeight="10.0" prefHeight="30.0" vgrow="SOMETIMES" /> | ||
| </rowConstraints> | ||
| <children> | ||
| <Label alignment="TOP_CENTER" styleClass="lidr-device-title-label" text="Semantic Details Added" textAlignment="CENTER" GridPane.columnIndex="1"> |
Contributor
There was a problem hiding this comment.
I left this comment in the PR but leaving here for better context:
The text might be off... It might be off already in the Figma... We are editing not adding but the text says: "Semantic Details Added"
Contributor
There was a problem hiding this comment.
We discussed as a team and we're going to leave it for now since it matches the figma.
stenkarl
approved these changes
Feb 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://ikmdev.atlassian.net/browse/IIA-1350
window before clicking submit:
window after clicking submit:
window after clicking close properties panel:
