Feature/IIA-1228: Implement ready only and edit interfaces on an Integer field. #217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi Bhavani @bhharsh13 ! Can you possibly tweak the title of the PR. We usually follow this pattern:
So, this would look like: "Feature/IIA-1228: Implement ready only and edit interfaces on an Integer field" Another thing worth adding is a link to the jira ticket in the issue description. Thanks! :) |
bhharsh13
changed the title
dukke
approved these changes
Jan 16, 2025
Contributor
dukke
left a comment
dukke
left a comment
There was a problem hiding this comment.
Nice @bhharsh13
All looks good to me just had that minor comment.
Contributor
Author
|
Closing the PR due to some more amendments to other's PR which are dependent |
Contributor
Author
|
Closing this PR due to change in the implementation strategy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement ready only and edit interfaces on an Integer field.
https://ikmdev.atlassian.net/browse/IIA-1228
Please find the attached screenshots of the changes validated on local.
Clicking on edit to update the integer value to 10 and clicking on Submit button.
Close the Pattern and re-open the Semantic Pattern window reflecting the updated Integer value.
