-
Notifications
You must be signed in to change notification settings - Fork 39
BugFix/IIA-1191: All the icons in komet app - Journal, on the left hand panel looks stretched #208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…nd panel looks stretched
dholubek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have a comment about using ubiquitous .icon class here.
| * * | ||
| ******************************************************************************/ | ||
|
|
||
| .icon { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are we sure this won't break anything? do all the icons in Komet have a background color white?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. I've removed that css definition and moved it to the icon-klcontext-menu styleclass to make sure it only applies to the context menu icons
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add some before and after images in the PR?
I feel this fix is only localized, I thought something happened recently when we switched out something. Lot's of other buttons and icons (graphic of button/toggle, svgnode, regions, etc.) in other screens are also squished.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@carldea Images have been attached to the issue
…g white to the icon-klcontext-menu styleclass
# Conflicts: # kview/src/main/java/dev/ikm/komet/kview/controls/skin/KLReadOnlyStringControlSkin.java
dholubek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved
dholubek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved
Fixes https://ikmdev.atlassian.net/browse/IIA-1191
Before
After