BugFix/IIA-1150: Selecting the "Patterns" pane on the left makes the scrollbars in the desktop area disappear

[dukke]

Fixes https://ikmdev.atlassian.net/browse/IIA-1150

Actual Behavior

Selecting the "Patterns" pane on the left makes the scrollbars in the desktop area disappear.

Expected Behavior

Selecting the “Patterns” pane should have no effect on the desktop area

Steps to Reproduce

1 - double click a Journal to open a Journal Window

2 - click to open the Navigator tray pane

3 - select the “Patterns” toggle

The scrollbars on the desktop area will disappear (pictures attached show the before and after)

[dholubek]

looks good

[carldea]

Looks good. Interesting to notice StackPane removal of minHeight attribute.
I will merge.

[carldea]

I think something is still not working correct.
The desktop area needs scroll bars to appear. The desktop (aka scalable desktop) should allow the user to pan around using the Control key + mouse moving (panning).

[dukke]

Looks good. Interesting to notice StackPane removal of minHeight attribute.
I will merge.

Yes, the Pane doesn't honor the min height but VerticallyFilledPane does that's why we need this change. 😊

I think something is still not working correct. The desktop area needs scroll bars to appear. The desktop (aka scalable desktop) should allow the user to pan around using the Control key + mouse moving (panning).

Hey @carldea I don't understand... You mean you tried running Komet with this PR and it's still not working on your side?

It's working on my end (at least I think it is). This is how it's working with the fix in this PR on my end:

Edit: I think I see where the confusion might be, the pictures that I attached to the description of the PR are describing the bug and are showing the bug happening. Those pictures are all from before the fix in this PR. I should have been clearer probably

2024-12-11.18-14-48.mp4

[swaroopsalvi]

Can you look why we cannot scroll to the last record of the pattern?

[dukke]

Can you look why we cannot scroll to the last record of the pattern?

That’s one of the other things this PR solves

[carldea]

Looks good. Interesting to notice StackPane removal of minHeight attribute.
I will merge.

Yes, the Pane doesn't honor the min height but VerticallyFilledPane does that's why we need this change. 😊

I think something is still not working correct. The desktop area needs scroll bars to appear. The desktop (aka scalable desktop) should allow the user to pan around using the Control key + mouse moving (panning).

Hey @carldea I don't understand... You mean you tried running Komet with this PR and it's still not working on your side?

It's working on my end (at least I think it is). This is how it's working with the fix in this PR on my end:

Edit: I think I see where the confusion might be, the pictures that I attached to the description of the PR are describing the bug and are showing the bug happening. Those pictures are all from before the fix in this PR. I should have been clearer probably

2024-12-11.18-14-48.mp4

Oh sorry for the confusion! yes I must have looked at the wrong image. Super glad this works! Like what @swaroopsalvi said, I am glad this ticket also fixes the listing of Patterns in the navigator.
Will merge. Thank you.

[carldea]

Looks good to me.

[dukke]

Looks good. Interesting to notice StackPane removal of minHeight attribute.
I will merge.

Yes, the Pane doesn't honor the min height but VerticallyFilledPane does that's why we need this change. 😊

I think something is still not working correct. The desktop area needs scroll bars to appear. The desktop (aka scalable desktop) should allow the user to pan around using the Control key + mouse moving (panning).

Hey @carldea I don't understand... You mean you tried running Komet with this PR and it's still not working on your side?
It's working on my end (at least I think it is). This is how it's working with the fix in this PR on my end:
Edit: I think I see where the confusion might be, the pictures that I attached to the description of the PR are describing the bug and are showing the bug happening. Those pictures are all from before the fix in this PR. I should have been clearer probably
2024-12-11.18-14-48.mp4

Oh sorry for the confusion! yes I must have looked at the wrong image. Super glad this works! Like what @swaroopsalvi said, I am glad this ticket also fixes the listing of Patterns in the navigator. Will merge. Thank you.

My bad actually, I should have written a better explanation in the issue description. I can see how that would have led to your confusion.
Thanks @carldea !