Merged
Conversation
carldea
reviewed
Nov 21, 2024
classification/src/main/java/dev/ikm/komet/reasoner/ReasonerResultsNode.java
Show resolved
Hide resolved
carldea
reviewed
Nov 21, 2024
| private void elkOwlReasonerIncremental(ActionEvent actionEvent) { | ||
| reinferAllHierarchy = false; | ||
| private void runIncrementalReasoner() { | ||
| if (!confirmRun("incremental")) |
Contributor
There was a problem hiding this comment.
Can we make literal Strings as constants? magic values: "incremental"?
Contributor
Author
There was a problem hiding this comment.
Don't know what magic values are
Contributor
There was a problem hiding this comment.
I meant magic numbers. You might consider making an enum or constant string.
enum ReasonerRunState {
INCREMENTAL,
FULL
}
// or
public static final String INCREMENTAL = "incremental";
...// later in code
if (!confirmRun(INCREMENTAL)) {
// stuff
}https://stackoverflow.com/questions/47882/what-are-magic-numbers-and-why-do-some-consider-them-bad
carldea
reviewed
Nov 21, 2024
| if (this.reasonerService == null) { | ||
| this.reasonerService = rs; | ||
| item.setSelected(true); | ||
| } else if (rs.getName().equals("ElkSnomedReasonerService")) { |
Contributor
There was a problem hiding this comment.
Can we make literal Strings as constants? magic values: "ElkSnomedReasonerService"?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.