feat(new bot): Added HypernymBot to the game #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Imported in the main.py file to use it In Board.py change the method to load the words file using utf8
ikeinyyo
requested changes
Jun 10, 2022
src/bots/HypernymBot.py
Outdated
| return similarity | ||
|
|
||
|
|
||
| def __get_first_common_hypernym(self, word1, word2, lang = 'spa'): |
There was a problem hiding this comment.
Revert this change and use a converter to translate language to wn_language
src/bots/HypernymBot.py
Outdated
|
|
||
| def give_answer(self, clue): | ||
| clue = str.lower(clue) | ||
| triple_list = list(map(lambda word: (word, self.__get_first_common_hypernym(clue, word)), self._board.get_available_words())) |
There was a problem hiding this comment.
Change triple_list by a better name
src/bots/HypernymBot.py
Outdated
|
|
||
| def __get_path_similarity(self, synset1, synset2): | ||
| similarity = wn.path_similarity(synset1, synset2) | ||
| similarity = similarity if similarity else 0 |
src/bots/HypernymBot.py
Outdated
|
|
||
|
|
||
| def __get_first_common_hypernym(self, word1, word2, lang = 'spa'): | ||
| try: |
There was a problem hiding this comment.
I don't want to review this code. Please, refactor this code using better names, methods, and other techniques. Then we can talk.
Add Pylint fix all pylint warnings Add dataclass Add types annotations Fix pylint Change name
Imported in the main.py file to use it In Board.py change the method to load the words file using utf8 Rebase branch into refactor to include pylint and the last changes
…reviously with uppercase now with lowercase
ikeinyyo
approved these changes
Sep 9, 2022
|
Fran approved this code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added HypernymBot to the game
Imported in the main.py file to use it
In Board.py change the method to load the words file using utf8