Add necessary support for Adaptive Lightning #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The HomeKit requires three characteristics to be advertised by the light source in order to be recognized as having support for adaptive lightning. Create definitions for these characteristics and add them as optional for the lightbulb service. Signed-off-by: Vít Kabele <vit@kabele.me>
Add implementation of a dummy lightbulb advertising Color Temperature, Brightness and three required characteristics for Adaptive Lightning. This virtual lightbulb can be added as an accessory with Adaptive Lightning support. Signed-off-by: Vít Kabele <vit@kabele.me>
Codecov Report
@@ Coverage Diff @@
## dev #428 +/- ##
==========================================
- Coverage 91.72% 91.63% -0.10%
==========================================
Files 20 20
Lines 2128 2140 +12
Branches 262 264 +2
==========================================
+ Hits 1952 1961 +9
- Misses 134 136 +2
- Partials 42 43 +1
|
|
When it will be integrated into HA? :) I am looking forward to it. Thanks for the work. |
Not sure about that. I'm currently trying to figure out how exactly the integration should look. Please see related discussion at HA forum. I'll be happy for any suggestion. |
|
So I have tried to add this characteristics in the custome component and then expose to apple home but adaptive light feature is not there in my light controller in apple home |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add necessary characteristics to enable implementation of Adaptive Lightning. Also provide a demo light bulb implementation to demonstrate the basic usage of the newly added characteristics.
This PR closes #284