-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for orjson #412
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #412 +/- ##
=======================================
Coverage 91.78% 91.78%
=======================================
Files 20 20
Lines 2118 2119 +1
Branches 287 287
=======================================
+ Hits 1944 1945 +1
Misses 132 132
Partials 42 42
|
ce559bb
to
d0ff5bd
Compare
ikalchev
reviewed
Jun 27, 2022
- orjson is used if its available. As Home Assistant is adding support for it, it will automaticlly be used when HAP-python is used with HA
Retesting now |
Manual testing looks good 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
orjson is now used. As Home Assistant has added
support for it, it will automatically be used when HAP-python
is used with HA
python's built in json is much slower and this improves the reconnect time when switching from out of home to home, and helps reduce the risk we will hit the lower timeouts in iOS 16 and have the bridge go unavailable on slower platforms