-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Protocol 1.1: Upgrade protocol version (HAP-python 4.0.0) #365
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #365 +/- ##
==========================================
- Coverage 91.28% 91.07% -0.22%
==========================================
Files 20 20
Lines 2008 1949 -59
Branches 240 225 -15
==========================================
- Hits 1833 1775 -58
Misses 131 131
+ Partials 44 43 -1
|
Looks like we are almost there but we have to implement the |
Will wait for a final nod from you before merging this and releasing |
Also I think some tests fail, mind if you take look if you do any final touches here? |
On it
… On Jul 29, 2021, at 2:45 PM, Ivan Kalchev ***@***.***> wrote:
Also I think some tests fail, mind if you take look if you do any final touches here?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#365 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFB7CCLYSDCTVVQ2HLPDOTT2GVWHANCNFSM5A7AQSOA>.
|
Thanks! I suspect sloppy merging on my part, so apologies. |
One of the PRs changed the behavior of the other.
All fixed in
#369
… On Jul 29, 2021, at 2:47 PM, Ivan Kalchev ***@***.***> wrote:
Thanks! I suspect sloppy merging on my part, so apologies.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#365 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFB7CDP364U624HBQFYKODT2GV4JANCNFSM5A7AQSOA>.
|
Ideally what is merged now can be released as 3.5.3 or 3.6.0 and then merge this and release at 4.0.0 so we can do a bump in Home Assistant for 3.x and then in next month 4.x so the protocol version change and the other changes just merged get independent feedback |
rebased to make sure this is clean against dev |
TODO: