Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protocol 1.1: Upgrade protocol version (HAP-python 4.0.0) #365

Merged
merged 1 commit into from
Jul 30, 2021

Conversation

bdraco
Copy link
Contributor

@bdraco bdraco commented Jul 25, 2021

@codecov
Copy link

codecov bot commented Jul 25, 2021

Codecov Report

Merging #365 (11590c9) into dev (fddedae) will decrease coverage by 0.21%.
The diff coverage is 100.00%.

❗ Current head 11590c9 differs from pull request most recent head 078214d. Consider uploading reports for the commit 078214d to get more accurate results

@@            Coverage Diff             @@
##              dev     #365      +/-   ##
==========================================
- Coverage   91.28%   91.07%   -0.22%     
==========================================
  Files          20       20              
  Lines        2008     1949      -59     
  Branches      240      225      -15     
==========================================
- Hits         1833     1775      -58     
  Misses        131      131              
+ Partials       44       43       -1     
Impacted Files Coverage Δ
pyhap/accessory_driver.py 90.46% <ø> (-0.58%) ⬇️
pyhap/accessory.py 96.62% <100.00%> (+0.24%) ⬆️
pyhap/const.py 100.00% <100.00%> (ø)
pyhap/hap_handler.py 81.23% <0.00%> (-0.57%) ⬇️
pyhap/characteristic.py 100.00% <0.00%> (ø)
pyhap/hap_protocol.py 100.00% <0.00%> (+0.62%) ⬆️

@bdraco bdraco marked this pull request as ready for review July 26, 2021 00:39
@bdraco bdraco marked this pull request as draft July 26, 2021 01:40
@bdraco
Copy link
Contributor Author

bdraco commented Jul 26, 2021

Looks like we are almost there but we have to implement the /prepare endpoint and timed writes

@bdraco bdraco changed the title Upgrade protocol version to 1.1.0 WIP: Upgrade protocol version to 1.1.0 (future) Jul 26, 2021
@bdraco bdraco changed the title WIP: Upgrade protocol version to 1.1.0 (future) Upgrade protocol version to 1.1.0 (HAP-python 4.0.0) Jul 26, 2021
@bdraco bdraco changed the title Upgrade protocol version to 1.1.0 (HAP-python 4.0.0) Protocol 1.1: Upgrade protocol version (HAP-python 4.0.0) Jul 26, 2021
@ikalchev
Copy link
Owner

Will wait for a final nod from you before merging this and releasing

@ikalchev
Copy link
Owner

Also I think some tests fail, mind if you take look if you do any final touches here?

@bdraco
Copy link
Contributor Author

bdraco commented Jul 29, 2021 via email

@ikalchev
Copy link
Owner

Thanks! I suspect sloppy merging on my part, so apologies.

@bdraco
Copy link
Contributor Author

bdraco commented Jul 29, 2021 via email

@bdraco
Copy link
Contributor Author

bdraco commented Jul 29, 2021

Ideally what is merged now can be released as 3.5.3 or 3.6.0 and then merge this and release at 4.0.0 so we can do a bump in Home Assistant for 3.x and then in next month 4.x so the protocol version change and the other changes just merged get independent feedback

@bdraco bdraco marked this pull request as ready for review July 29, 2021 20:18
@bdraco
Copy link
Contributor Author

bdraco commented Jul 29, 2021

rebased to make sure this is clean against dev

@ikalchev ikalchev merged commit 1b71e84 into ikalchev:dev Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants